? ?

Success

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
15 Oct 2015

Issue

Currently, the frontend en-GB.localise.php is a bit different in codestyle from the backend one.
This isn't an issue by itself, but since they are actually identical files otherwise, it makes sense to make the identical :smile:
Having them identical helps when translators use a translation tool (eg Crowdin) since the "Translation Memory" and duplicate string detection will then automatically "translate" the other file for them.

Solution

I just copied the backend file over to the frontend.

Testing

There is nothing really to test, code does the same before and after and since it works in backend, it will also work in frontend :smile:
Imho, it can be merged on review.

avatar Bakual Bakual - open - 15 Oct 2015
avatar Bakual Bakual - change - 15 Oct 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Oct 2015
Labels Added: ? ?
avatar zero-24 zero-24 - change - 15 Oct 2015
Status Pending Ready to Commit
avatar zero-24 zero-24 - change - 15 Oct 2015
Category Code style
avatar zero-24
zero-24 - comment - 15 Oct 2015

RTC on review.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8096.

avatar joomla-cms-bot joomla-cms-bot - change - 15 Oct 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 15 Oct 2015
Milestone Added:
avatar wilsonge wilsonge - change - 15 Oct 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-10-15 12:29:34
Closed_By wilsonge
avatar wilsonge wilsonge - reference | 0c14bc9 - 15 Oct 15
avatar wilsonge wilsonge - merge - 15 Oct 2015
avatar wilsonge wilsonge - close - 15 Oct 2015
avatar Bakual Bakual - head_ref_deleted - 15 Oct 2015
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone
avatar wilsonge wilsonge - change - 17 Jan 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment