Feeling Lucky
?
[#8091] - Update UCMContentHistory: Fixes
- Closed
- 24 Oct 2015
- Medium
- Build: staging
- # 8091
- Diff
- izharaazmi:ucm_history
- Success Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Update UCMContentHistory: Fixed unquoted property value in SQL causing error. Consistent use of getter.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Libraries |
izharaazmi
- comment
- 15 Oct 2015
Here are the test instructions:
$table = JTable::getInstance('Contenthistory', 'JTable');
$table->getHashMatch();Without this patch:
You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'AND `ucm_type_id` = AND `sha1_hash` = '' LIMIT 0, 1' at line 3 SQL=SELECT * FROM `sa34_ucm_history` WHERE `ucm_item_id` = AND `ucm_type_id` = AND `sha1_hash` = '' LIMIT 0, 1
No error after this patch.
Same approach can be applied to ContenthistoryModelHistory::getListQuery()
NOTE: Such errors occurs when ucm_item_id or ucm_type_id is 0 or non-numeric string as they are unquoted literals.
degobbis
- comment
- 24 Oct 2015
I have tested this item 
successfully on d35aad4
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8091.
yvesh
- comment
- 24 Oct 2015
I have tested this item successfully on d35aad4
@Test working fine
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8091.
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
zero-24
- comment
- 24 Oct 2015
| Labels |
Added:
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-10-24 14:31:23 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
| Milestone | |||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone | |||
@izharaazmi can you add some testinstructions?