?

Success

User tests: Successful: Unsuccessful:

avatar izharaazmi
izharaazmi
14 Oct 2015

Update UCMContentHistory: Fixed unquoted property value in SQL causing error. Consistent use of getter.

avatar izharaazmi izharaazmi - open - 14 Oct 2015
avatar izharaazmi izharaazmi - change - 14 Oct 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Oct 2015
Labels Added: ?
avatar zero-24
zero-24 - comment - 14 Oct 2015

@izharaazmi can you add some testinstructions?

avatar zero-24 zero-24 - change - 14 Oct 2015
Category Libraries
avatar izharaazmi
izharaazmi - comment - 15 Oct 2015

Here are the test instructions:

$table = JTable::getInstance('Contenthistory', 'JTable');
$table->getHashMatch();

Without this patch:

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'AND `ucm_type_id` = AND `sha1_hash` = '' LIMIT 0, 1' at line 3 SQL=SELECT * FROM `sa34_ucm_history` WHERE `ucm_item_id` = AND `ucm_type_id` = AND `sha1_hash` = '' LIMIT 0, 1

No error after this patch.

Same approach can be applied to ContenthistoryModelHistory::getListQuery()

NOTE: Such errors occurs when ucm_item_id or ucm_type_id is 0 or non-numeric string as they are unquoted literals.

avatar degobbis degobbis - test_item - 24 Oct 2015 - Tested successfully
avatar degobbis
degobbis - comment - 24 Oct 2015

I have tested this item :white_check_mark: successfully on d35aad4


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8091.

avatar yvesh yvesh - test_item - 24 Oct 2015 - Tested successfully
avatar yvesh
yvesh - comment - 24 Oct 2015

I have tested this item :white_check_mark: successfully on d35aad4

@Test working fine


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8091.

avatar zero-24 zero-24 - change - 24 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 24 Oct 2015
Milestone Added:
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 24 Oct 2015

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8091.

avatar joomla-cms-bot joomla-cms-bot - change - 24 Oct 2015
Labels Added: ?
avatar rdeutz rdeutz - reference | cf753c2 - 24 Oct 15
avatar rdeutz rdeutz - merge - 24 Oct 2015
avatar rdeutz rdeutz - close - 24 Oct 2015
avatar rdeutz rdeutz - change - 24 Oct 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-10-24 14:31:23
Closed_By rdeutz
avatar rdeutz rdeutz - close - 24 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - close - 24 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - change - 24 Oct 2015
Labels Removed: ?
avatar izharaazmi izharaazmi - head_ref_deleted - 24 Oct 2015
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone

Add a Comment

Login with GitHub to post a comment