User tests: Successful: Unsuccessful:
Well, we use JHtml for rendering the body of the modal for the batch commands but there are not many arguments passed neither some complex computation for this particular task. Therefore we can drop the JHtml and use JLayout directly here.
I already replaced all the old instances, so other devs can use as an example for their code.
The proposal is to remove the file batch.php from the html folder in v4.
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
More coffee then...
![]()
Also, Travis does not look happy.
Missing doc block and some spaces, minors. The code works, but before I go on and spent more time here I would like to hear if there are any objection for this. I suspect the path might not be optimal, depending on the renderer implementation (?)
| Labels |
Added:
?
|
||
I have just add some inline comments. But in generaly it looks good to me. Give me a ping if you fixed the comments above than i can test it ;)
| Category | ⇒ | Administration Layout Libraries |
| Easy | No | ⇒ | Yes |
I doubt anyone's actually doing this but if you shift something from using JHtml in full to not then it breaks overrides if someone is using JHtml's override system. Since we're being so anal retentive on B/C, it has to be said.
Specifically the JHtml::register() API (https://github.com/mbabker/bs3-demo/blob/master/plg_system_bootstrap3/bootstrap3.php). If you don't call the JHtml method, then if someone actually registered an override, their overridden method won't get called.
Ah, yeah I did the direct call to JLayout here, which shouldn’t be really here but part of the 4
I have tested this item
successfully on 009786a
Test erfolgreich durchgeführt
I have tested this item
successfully on 009786a
it works for my
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
| Labels |
Added:
?
Removed: ? |
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-10-24 13:12:18 |
| Closed_By | ⇒ | Kubik-Rubik |
| Labels |
Removed:
?
|
||
| Milestone | |||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone | |||
+ <?php echo JLayoutHelper::render('joomla.html.batch.item', $dispalyData = array('extension' => 'com_banners')); ?>typo I guess, also elsewhere in PR
$dispalyData=>$displayData