? Success

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
14 Oct 2015

What is this?

Well, we use JHtml for rendering the body of the modal for the batch commands but there are not many arguments passed neither some complex computation for this particular task. Therefore we can drop the JHtml and use JLayout directly here.
I already replaced all the old instances, so other devs can use as an example for their code.
The proposal is to remove the file batch.php from the html folder in v4.

avatar dgt41 dgt41 - open - 14 Oct 2015
avatar dgt41 dgt41 - change - 14 Oct 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Oct 2015
Labels Added: ?
avatar infograf768
infograf768 - comment - 14 Oct 2015

+ <?php echo JLayoutHelper::render('joomla.html.batch.item', $dispalyData = array('extension' => 'com_banners')); ?>

typo I guess, also elsewhere in PR
$dispalyData => $displayData
:smile:

avatar dgt41
dgt41 - comment - 14 Oct 2015

More coffee then...

avatar infograf768
infograf768 - comment - 14 Oct 2015

:smile:

Also, Travis does not look happy.

avatar dgt41
dgt41 - comment - 14 Oct 2015

Missing doc block and some spaces, minors. The code works, but before I go on and spent more time here I would like to hear if there are any objection for this. I suspect the path might not be optimal, depending on the renderer implementation (?)

avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Added: ?
avatar zero-24
zero-24 - comment - 14 Oct 2015

I have just add some inline comments. But in generaly it looks good to me. Give me a ping if you fixed the comments above than i can test it ;)

avatar zero-24 zero-24 - change - 14 Oct 2015
Category Administration Layout Libraries
avatar zero-24 zero-24 - change - 14 Oct 2015
Easy No Yes
avatar mbabker
mbabker - comment - 14 Oct 2015

I doubt anyone's actually doing this but if you shift something from using JHtml in full to not then it breaks overrides if someone is using JHtml's override system. Since we're being so anal retentive on B/C, it has to be said.

avatar dgt41
dgt41 - comment - 14 Oct 2015

@mbabker if someone overrides libraries/cms/html/batch.php i guess whatever stuff the core uses want make any difference, they will write their own html part on their overrides. Am I overseeing stuff here?

avatar mbabker
mbabker - comment - 14 Oct 2015

Specifically the JHtml::register() API (https://github.com/mbabker/bs3-demo/blob/master/plg_system_bootstrap3/bootstrap3.php). If you don't call the JHtml method, then if someone actually registered an override, their overridden method won't get called.

avatar dgt41
dgt41 - comment - 14 Oct 2015

Ah, yeah I did the direct call to JLayout here, which shouldn’t be really here but part of the 4

avatar dgt41
dgt41 - comment - 16 Oct 2015

@mbabker I adjusted the code so it will be 100% B/C for the 3.x. Thanks for the input!

8214307 16 Oct 2015 avatar dgt41 CS
avatar zero-24
zero-24 - comment - 20 Oct 2015

How to test

avatar designbengel designbengel - test_item - 24 Oct 2015 - Tested successfully
avatar designbengel
designbengel - comment - 24 Oct 2015

I have tested this item :white_check_mark: successfully on 009786a


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8088.

avatar widmann-it
widmann-it - comment - 24 Oct 2015

Test erfolgreich durchgeführt

avatar KarstenBln KarstenBln - test_item - 24 Oct 2015 - Tested successfully
avatar KarstenBln
KarstenBln - comment - 24 Oct 2015

I have tested this item :white_check_mark: successfully on 009786a

it works for my


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8088.

avatar zero-24 zero-24 - change - 24 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 24 Oct 2015
Milestone Added:
Status Pending Ready to Commit
Labels
avatar Kubik-Rubik Kubik-Rubik - change - 24 Oct 2015
Labels Added: ?
Removed: ?
avatar Kubik-Rubik
Kubik-Rubik - comment - 24 Oct 2015

Thank you @dgt41 and testers! Merged.

avatar Kubik-Rubik Kubik-Rubik - reference | f5eaa5f - 24 Oct 15
avatar Kubik-Rubik Kubik-Rubik - merge - 24 Oct 2015
avatar Kubik-Rubik Kubik-Rubik - close - 24 Oct 2015
avatar Kubik-Rubik Kubik-Rubik - change - 24 Oct 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-10-24 13:12:18
Closed_By Kubik-Rubik
avatar Kubik-Rubik Kubik-Rubik - close - 24 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - close - 24 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - change - 24 Oct 2015
Labels Removed: ?
avatar dgt41 dgt41 - head_ref_deleted - 27 Oct 2015
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone

Add a Comment

Login with GitHub to post a comment