Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#8080] - Code review on admin com_banners component

? Success

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
12 Oct 2015

This PR is a general overview and cleanup of some code structure and doc blocks in the admin com_banners component. Changes of note:

  • Doc blocks cleaned up some to follow standard
  • Return the results of the view's display() methods to be consistent with the documented return
  • Not using variables for items only referenced once
  • Use Joomla\Utilities\ArrayHelper instead of JArrayHelper

Testing Instructions

The admin com_banners component should continue to function correctly

avatar mbabker mbabker - open - 12 Oct 2015
avatar mbabker mbabker - change - 12 Oct 2015
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Oct 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 12 Oct 2015
Category ⇒ Administration Components
avatar zero-24 zero-24 - change - 12 Oct 2015
Easy No ⇒ Yes
avatar coolman01 coolman01 - test_item - 24 Oct 2015 - Tested successfully
avatar coolman01
coolman01 - comment - 24 Oct 2015

I have tested this item :white_check_mark: successfully on d3e2c82

created banner
created customer
created module
published all
all tests including banner click successful

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8080.

avatar widmann-it
widmann-it - comment - 24 Oct 2015

is working

avatar SniperSister SniperSister - alter_testresult - 24 Oct 2015 - widmann-it: Tested successfully
avatar SniperSister SniperSister - change - 24 Oct 2015
Status Pending ⇒ Ready to Commit
avatar SniperSister
SniperSister - comment - 24 Oct 2015

2 successful tests, setting RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8080.

avatar joomla-cms-bot joomla-cms-bot - change - 24 Oct 2015
Labels Added: ?
avatar Kubik-Rubik Kubik-Rubik - change - 24 Oct 2015
Milestone Added:
avatar Kubik-Rubik
Kubik-Rubik - comment - 24 Oct 2015

Thank you @mbabker and testers! Merged.

avatar Kubik-Rubik Kubik-Rubik - change - 24 Oct 2015
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-10-24 13:16:59
Closed_By ⇒ Kubik-Rubik
avatar Kubik-Rubik Kubik-Rubik - close - 24 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - close - 24 Oct 2015
avatar Kubik-Rubik Kubik-Rubik - reference | 4220f68 - 24 Oct 15
avatar Kubik-Rubik Kubik-Rubik - merge - 24 Oct 2015
avatar Kubik-Rubik Kubik-Rubik - close - 24 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - change - 24 Oct 2015
Labels Removed: ?
avatar mbabker mbabker - head_ref_deleted - 24 Oct 2015
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone

Add a Comment

Login with GitHub to post a comment