Feeling Lucky
?
[#8078] - Code review on com_admin component
- Closed
- 24 Oct 2015
- Medium
- Build: staging
- Easy Test
- # 8078
- Diff
- mbabker:code-review
- Success Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
This PR is a general overview and cleanup of some code structure and doc blocks in the com_admin component. Changes of note:
- Doc blocks cleaned up some to follow standard
- Default object types set to match the documented type
- Not using variables for items only referenced once
- Construct of the arrays in the sysinfo model
- Renamed private
_addDirectory()method toaddDirectory()to comply with code style - Return the results of the view's
display()methods to be consistent with the documented return
Testing Instructions
Pages from com_admin (the System Information, Joomla! Help, and the Edit Account menu items) function correctly pre- and post- patch.
Votes
# of Users Experiencing Issue
1/1
Average Importance Score
3.00
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
zero-24
- | Easy | No | ⇒ | Yes |
| Category | ⇒ | Administration Components |
kolvar
- comment
- 24 Oct 2015
I have tested this item 
successfully on 9ef1632
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8078.
matrikular
- comment
- 24 Oct 2015
I have tested this item successfully on 9ef1632
Tested by code review
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8078.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-10-24 10:08:46 |
| Closed_By | ⇒ | Bakual |
Bakual
- comment
- 24 Oct 2015
Merged, thanks!
| Milestone |
Added: |
||
jduerscheid
- comment
- 24 Oct 2015
Tested sucessful
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8078.
widmann-it
- comment
- 24 Oct 2015
Works
| Milestone | |||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone | |||
tested with the given com_admin-Pages. Works.