? Success

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
11 Oct 2015

In JTable::store() there exists a use case where the $result variable, which should be a boolean and is used as such in observers, can be set as the database cursor object which introduces the potential for code to handle that variable incorrectly. This PR updates the $result variable to default to a true value and only in error conditions that already exist is when it gets set to false. We no longer catch the result of the JDatabaseDriver (insert/update)Object methods as well as it is unused.

Testing Instructions

Saving items should still work.

avatar mbabker mbabker - open - 11 Oct 2015
avatar mbabker mbabker - change - 11 Oct 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Oct 2015
Labels Added: ?
avatar rdeutz rdeutz - test_item - 11 Oct 2015 - Tested successfully
avatar rdeutz
rdeutz - comment - 11 Oct 2015

I have tested this item :white_check_mark: successfully on 07505ee


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8062.

avatar zero-24 zero-24 - test_item - 11 Oct 2015 - Tested successfully
avatar zero-24
zero-24 - comment - 11 Oct 2015

I have tested this item :white_check_mark: successfully on 07505ee

Works good. Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8062.

avatar zero-24 zero-24 - change - 11 Oct 2015
Status Pending Ready to Commit
Easy No Yes
avatar zero-24 zero-24 - change - 11 Oct 2015
Category Libraries
avatar zero-24
zero-24 - comment - 11 Oct 2015

RTC Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8062.

avatar joomla-cms-bot joomla-cms-bot - change - 11 Oct 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 11 Oct 2015
Milestone Added:
avatar rdeutz rdeutz - change - 11 Oct 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-10-11 20:53:43
Closed_By rdeutz
avatar rdeutz rdeutz - close - 11 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - close - 11 Oct 2015
avatar rdeutz rdeutz - reference | 319bc75 - 11 Oct 15
avatar rdeutz rdeutz - merge - 11 Oct 2015
avatar rdeutz rdeutz - close - 11 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - change - 11 Oct 2015
Labels Removed: ?
avatar mbabker mbabker - head_ref_deleted - 11 Oct 2015
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone

Add a Comment

Login with GitHub to post a comment