[#8057] - Messaging - remove duplicate submenu item
- Closed
- 4 Nov 2015
- Medium
- Build: staging
- Easy Test
- # 8057
- Diff
- pe7er:components-messaging
- Success Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
This PR removes the duplicate menu item in the Messaging submenu.
IMHO offering less (duplicate) options is better for UX.
Testing instructions
Before this PR
Components > Messaging (shows list of private messages) has two submenus:
- New Private Message (create new private message form)
- Read Private Messages (shows list of private messages) which is a duplicate of the parent Messaging menu item
Other components, like com_content, do not have such duplicate options.
See Content > Articles (shows list of articles) > has one submenu item Add New Article (create new article form)
After this PR
The administrator menu items are created from records in the database.
The database settings are created upon installation and therefore the testing procedure is a bit different:
- Install the patch
- remove configuration.php
- install Joomla again
- check the new menu settings:
Components > Messaging now has only one submenu: New Private Message
Note: I have only removed the duplicate menu item in the MySQL files (Joomla core installation and all different sample data files), and in tests/system/webdriver/Pages/System/AdminPage.php and tests/unit/stubs/database/jos_menu.csv.
I have not yet changed it in Postgresql, nor in SQLAzure. I would like to have this PR tested before I'll make the necessary changes in those two databases.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
Quick comment without testing as I'm on a phone.
The 'add new' is usually governed by a setting in the admin menu module
On 11 Oct 2015 7:24 am, "Niels van der Veer" notifications@github.com
wrote:
For some strange reason, I can not apply this patch via the Joomla! Patch
tester. Is this a problem in my test installation?
This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/8057
http://issues.joomla.org/tracker/joomla-cms/8057.—
Reply to this email directly or view it on GitHub
#8057 (comment).
Did you reinstall Joomla after applying the patch?
The submenus of the components under the Components menu are retrieved from the database. And the database settings are created upon installation. Therefore you'll need to reinstall Joomla with the patched SQL files.
| Category | ⇒ | Administration UI/UX |
| Easy | No | ⇒ | Yes |
I can't not apply the patch. I have re-installed the newest joomla-cms-staging on my localhost.
This is the error what I get when I apply the patch:
Error
The patch could not be applied because it conflicts with a previously applied patch: installation/sql/mysql/joomla.sql
Hopefully can you fix this issue.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8057.
That's by design with the patch tester. What that means is that it has found a backup of that file in the administrator/components/com_patchtester/backups folder either from a previous patch or having not fully reverted a patch. When you're using the patch tester, you should ensure that you have reverted all patches before applying a new one, and if you still get this message after that, you need to delete any backups from that folder.
I have looked in the administrator/components/com_patchtester folder and this folder is empty.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8057.
I think the test description is not complete. The patch changes a file in the installation directory. I added the first list item.
- add the installation folder to your joomla installation
- Install the patch
- remove configuration.php
- install Joomla again
- check the new menu settings:
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8057.
I have tested this item 
successfully on 1a41dfb
I tested the patch with the changed test description in my comment. With this description the patch works for me.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8057.
I have tested this item successfully on 1a41dfb
Patch works as described.
Remember to update the IDs and also the lft, rgt values for the other entries in that table for the final version of this PR.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8057.
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
RTC @committer please take care on the comment by @matrikular
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8057.
| Labels |
Added:
?
|
||
@zero-24 The lft and rgt values do not need to be updated because the entries @pe7er is removing are not in the assets table. Only the main extension com_messages is in there but not the suboptions. The suboptions are only links to the component.
As for updating the ID's, I wouldn't go through the hassle. It would be a major hassle to reclaim number 12.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-11-04 14:28:13 |
| Closed_By | ⇒ | roland-d |
| Labels |
Removed:
?
|
||
For some strange reason, I can not apply this patch via the Joomla! Patch tester. Is this a problem in my test installation? Or are there people with the same problem?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8057.