[#8040] - [SEO] - Deleted tags not redirecting to 404 error page
- Closed
- 2 Nov 2015
- Medium
- Build: staging
- # 8040
- Diff
- FPerisa:staging
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
A Solution for issue #5148
The issue:
When an url of an unknown tag is requested, joomla handles this like an existing tag with the message "No matching items were found.". A 404 error should be thrown instead.
My solution:
When the tag ID (out of the given url) is searched in the database, I check the primary key of the "found" object. When there is no one, I throw the 404 error, with a "Tag not found." message.
Testing instructions:
- Enter an url with a tag that does not exist in your joomla.
- Important is the ID and not the name behind the minus.
- For example: localhost/example-page/index.php/all-tags/99-foo
Expected result:
A 404 error appears instead of a "No matching items were found." message.
Worked as a group on that issue: @icampus @flow87 @kathastaden @xsability
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
Thank you for your comment!
I will check my git problems (with the unnecessary commit) and sort the language file.
I have tested this item 
successfully on ec507fc
Before istalling the patch recieved the following message: No matching items were found.
After installing the patch: No matching items were found. (404 Tag not found. )
Result as expected
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8040.
I have tested this item successfully on ec507fc
404 is better to show indeed - Patch is working as expected and throwing a 404 now instead of a message.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8040.
| Milestone |
Added: |
||
@FPerisa Can you please fix the language ordering so we can merge this fix? Thank you.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8040.
I have tested this item successfully; with result as expected.
Test took place in the context of Pizza & Fun Bug JUG Rome.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8040.
I successfully tested, I think is a sensible change. The test took place in the Pizza and Fun JUG Rome.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8040.
| Status | Pending | ⇒ | Ready to Commit |
RTC since the language strings are now alpha ordered
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8040.
| Labels |
Added:
?
|
||
| Milestone | |||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone | |||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-11-02 20:14:39 |
| Closed_By | ⇒ | roland-d |
wilsonge
- | Labels |
Removed:
?
|
||
Language strings are normally ordered alphabetically so please can you update the proposed change in the language file