Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#8020] - Fix a failure in the Module List

? ? Success

User tests: Successful: Unsuccessful:

avatar astridx
astridx
5 Oct 2015

I made a great mess in issue #7221. Sorry for that. That’s why I have to close this and open the PR newly in this issue.

  1. See the failure

  2. Go to the Extensions | Modules and ensure, that you have at least two modules of the type search for the location site. One is published and another is unpublished.

  3. Switch to Extension Manager|Manage -> Manage and disable the Modul “Search” for the location site.

  4. Go back to Extensions | Module Manager and see, that the Status show wrong values. The published Module looks like unpublished and the unpublished value looks like trashed.

  5. Apply my patch

  6. Go to the Extensions | Module and ensure, that you have at least two modules of the type "Search" for the location site. One is published and another is unpublished.

  7. Switch to Extension Manager|Manage -> Manage and disable the Module “Search” for the location site.

  8. Go back to Extensions | Module Manager and see, that the Status did not show the wrong values any more. There is a new value for disabled modules with a message as tooltip.
    Sorry for the trouble about the new PR.

avatar astridx astridx - open - 5 Oct 2015
avatar astridx astridx - change - 5 Oct 2015
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Oct 2015
Labels Added: ? ?
avatar infograf768
infograf768 - comment - 6 Oct 2015

Needs some small code style corrections:

FOUND 2 ERROR(S) AND 1 WARNING(S) AFFECTING 2 LINE(S)

--------------------------------------------------------------------------------

 168 | WARNING | Expected 1 space after ">"; 0 found

 168 | ERROR   | Expected 1 space before ">"; 0 found

 170 | ERROR   | Whitespace found at end of line
avatar infograf768
infograf768 - comment - 6 Oct 2015

Also, there are 2 strings on the same line (Note: weird we have strings for archived modules when we cannot archive these...)

+COM_MODULES_MSG_MANAGE_EXTENSION_DISABLED="This module is disabled. Use Extensions => Manage to enable it." COM_MODULES_N_ITEMS_ARCHIVED="%d modules successfully archived."

Also:
Notice: Use of undefined constant php - assumed 'php' in /administrator/components/com_modules/views/modules/tmpl/default.php on line 179

Add a space between <?php and // Create dropdown items ?>

avatar zero-24
zero-24 - comment - 6 Oct 2015

@astridx i have just prepared a PR to fix the issues @infograf768 and Travis found ;) astridx#1

avatar zero-24 zero-24 - change - 6 Oct 2015
Easy No ⇒ Yes
avatar zero-24 zero-24 - change - 6 Oct 2015
Category ⇒ Administration UI/UX
avatar zero-24 zero-24 - test_item - 6 Oct 2015 - Tested successfully
avatar zero-24
zero-24 - comment - 6 Oct 2015

I have tested this item :white_check_mark: successfully on 1c0d7a3

Works great. Thanks @astridx :smile:

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8020.

avatar YouriiM26 YouriiM26 - test_item - 6 Oct 2015 - Tested successfully
avatar YouriiM26
YouriiM26 - comment - 6 Oct 2015

I have tested this item :white_check_mark: successfully on 1c0d7a3
Works correctly. Thanks!

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8020.

avatar zero-24 zero-24 - change - 6 Oct 2015
Status Pending ⇒ Ready to Commit
avatar zero-24
zero-24 - comment - 6 Oct 2015

RTC :smiley:

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8020.

avatar joomla-cms-bot joomla-cms-bot - change - 6 Oct 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 6 Oct 2015
Milestone Added:
avatar rdeutz rdeutz - reference | ee69bfc - 6 Oct 15
avatar rdeutz rdeutz - merge - 6 Oct 2015
avatar rdeutz rdeutz - close - 6 Oct 2015
avatar rdeutz rdeutz - change - 6 Oct 2015
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-10-06 12:49:09
Closed_By ⇒ rdeutz
avatar zero-24 zero-24 - alter_testresult - 6 Oct 2015 - test: Not tested
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone

Add a Comment

Login with GitHub to post a comment