Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#7987] - [fix #7986] Problem in searching with space using chosen

? Success
Pull Request for # 7986

User tests: Successful: Unsuccessful:

avatar gunjanpatel
gunjanpatel
30 Sep 2015

Steps to reproduce the issue

  • Create a category having space in name. For example: "Events and Forms"
  • Make sure you have more than 10 categories, if not try to copy it.
  • Go to article create/edit page, In category selection try to search "event and "

screen shot 2015-09-30 at 05 00 45

  • Now, close the article edit page and go to article listing page. Select any article and click on batch button from toolbar and try to search "event and " like below and notice it is working.

screen shot 2015-09-30 at 05 04 18

Expected result

It should looks like below in article edit page.
screen shot 2015-09-30 at 05 05 36

System information (as much as possible)

I have tested it in FF41.0 Ubuntu. But I believe it's not dependent on browser or OS.

avatar gunjanpatel gunjanpatel - open - 30 Sep 2015
avatar gunjanpatel gunjanpatel - change - 30 Sep 2015
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Sep 2015
Labels Added: ?
avatar javigomez javigomez - change - 30 Sep 2015
Rel_Number 0 ⇒ 7986
Relation Type ⇒ Pull Request for
avatar javigomez
javigomez - comment - 30 Sep 2015

The change fixes the issue:

screen shot 2015-09-30 at 13 00 01

avatar javigomez javigomez - test_item - 30 Sep 2015 - Tested successfully
avatar javigomez
javigomez - comment - 30 Sep 2015

I have tested this item :white_check_mark: successfully on deb74fe

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7987.

avatar Devportobello
Devportobello - comment - 30 Sep 2015

About B/C, you are altering the default value who was false Here

avatar gunjanpatel
gunjanpatel - comment - 1 Oct 2015

I think it will not, because that is core option this.search_contains = this.options.search_contains || false; and I am setting default option for joomla to set search_contains to true.
I think it is okay to enable search_contains it won't harm any functionality. Instead of that it will fix the bug with search using space in all select boxes.

avatar zero-24 zero-24 - test_item - 1 Oct 2015 - Tested successfully
avatar zero-24
zero-24 - comment - 1 Oct 2015

I have tested this item :white_check_mark: successfully on deb74fe

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7987.

avatar zero-24 zero-24 - change - 1 Oct 2015
Category ⇒ Administration UI/UX
avatar zero-24 zero-24 - change - 1 Oct 2015
Status Pending ⇒ Ready to Commit
Easy No ⇒ Yes
avatar zero-24
zero-24 - comment - 1 Oct 2015

Works good here. Thanks @gunjanpatel --> RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7987.

avatar joomla-cms-bot joomla-cms-bot - change - 1 Oct 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 1 Oct 2015
Milestone Added:
avatar rdeutz rdeutz - reference | 31c53bc - 1 Oct 15
avatar rdeutz rdeutz - merge - 1 Oct 2015
avatar rdeutz rdeutz - close - 1 Oct 2015
avatar rdeutz rdeutz - change - 1 Oct 2015
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-10-01 18:45:52
Closed_By ⇒ rdeutz
avatar rdeutz rdeutz - close - 1 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - close - 1 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - change - 1 Oct 2015
Labels Removed: ?
avatar gunjanpatel gunjanpatel - head_ref_deleted - 4 Oct 2015
avatar gunjanpatel
gunjanpatel - comment - 4 Oct 2015

Thank you for testing and merging.

avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone

Add a Comment

Login with GitHub to post a comment