Feeling Lucky
?
[#7970] - JDatabaseQuery::__toString() does not utilize unionAll query element
- Closed
- 15 Jul 2016
- Medium
- Build: master
- # 7970
Referenced as
Pull Request for:
# 10817
It is observed that the JDatabaseQuery::unionAll() method creates a JDatabaseQueryElement named unionAll see JDatabaseQuery::unionAll() which is never utilized when converting the JDatabaseQuery object to a real string query see JDatabaseQuery::__toString().
This results in an incorrect query string.
The unit test case uses Reflection class to get the value of unionAll element, which is not sufficient. Test case should be made as realistic as possible. see JDatabaseQueryTest::unionAllUnion()
There are multiple possible ways we can fix this, therefore I wanted to discuss it before making a PR.
zero-24
- | Labels |
Added:
?
|
||
| Category | ⇒ | Libraries Unit Tests |
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-07-15 06:01:50 |
| Closed_By | ⇒ | gunjanpatel |
joomla-cms-bot
- 
gunjanpatel
- comment
- 15 Jul 2016
Closing as we have PR
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7970.
Set to "closed" on behalf of @gunjanpatel by The JTracker Application at issues.joomla.org/joomla-cms/7970