Feeling Lucky
?
[#7967] - Example revision of the JHtmlTabs using JHtmlElement
- Closed
- 28 Sep 2015
- Medium
- Build: staging
- # 7967
- Diff
- Mathewlenning:JHtmlElement---tabs-revision-example
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Example of how pull request #7948 can simplify our lives.
This is less than ideal. I'd actually prefer to just send the wrapper and let the developer add the tab panes using the JHtmlElement interface.
But even in its current form it is way better than the current JHtmlTabs implementation.
BTW does anyone know why we are adding the empty dt/dd set? or can I remove it?
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
zero-24
- | Category | ⇒ | Libraries |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-09-28 12:35:42 |
| Closed_By | ⇒ | Mathewlenning |
@Mathewlenning I think you based this on the old html/tabs.php which is not the bootstrap version, thus the dd, dl elements and also the Mootools library dependency and the extra tabs.js script. The bootstrap version should be located inside the html/bootstrap.php file