Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#7965] - CLEANING - JFilesystemPatcher

? Success

User tests: Successful: Unsuccessful:

avatar Mathewlenning
Mathewlenning
28 Sep 2015

Cleaned up this class a little. Removed some redundant Else clauses and removed some redundant code.

avatar Mathewlenning Mathewlenning - open - 28 Sep 2015
avatar Mathewlenning Mathewlenning - change - 28 Sep 2015
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Sep 2015
Labels Added: ?
avatar zero-24
zero-24 - comment - 28 Sep 2015

@Mathewlenning Travis complaining on very minimal error ;)

FILE: .../travis/build/joomla/joomla-cms/libraries/joomla/filesystem/patcher.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 146 | ERROR | Functions and classes must not contain multiple empty lines in a
     |       | row; found 2 empty lines
--------------------------------------------------------------------------------
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
--------------------------------------------------------------------------------
avatar zero-24
zero-24 - comment - 28 Sep 2015

How to test.

  • Install clean joomla
  • install com_patchtester
  • install a patch (not this on here)
  • install this patch (ID: 7965)
  • install another patch
  • make sure we have no errors
  • revert all patches
  • alter your test here :smile:
avatar zero-24 zero-24 - change - 28 Sep 2015
Category ⇒ Libraries
avatar zero-24 zero-24 - change - 28 Sep 2015
Easy No ⇒ Yes
avatar Mathewlenning
Mathewlenning - comment - 28 Sep 2015

Thanks @zero-24 I'll fix the error in just a second.

avatar ceus1984 ceus1984 - test_item - 24 Oct 2015 - Tested successfully
avatar ceus1984
ceus1984 - comment - 24 Oct 2015

I have tested this item :white_check_mark: successfully on 099f6be

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7965.

avatar seagul30 seagul30 - test_item - 24 Oct 2015 - Tested successfully
avatar seagul30
seagul30 - comment - 24 Oct 2015

I have tested this item :white_check_mark: successfully on 099f6be

tested successfully!
installed like in test description

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7965.

avatar SniperSister SniperSister - change - 24 Oct 2015
Status Pending ⇒ Ready to Commit
avatar SniperSister
SniperSister - comment - 24 Oct 2015

2 successful tests, setting RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7965.

avatar joomla-cms-bot joomla-cms-bot - change - 24 Oct 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 24 Oct 2015
Milestone
avatar zero-24 zero-24 - change - 24 Oct 2015
Milestone
avatar Kubik-Rubik
Kubik-Rubik - comment - 24 Oct 2015

Thank you @Mathewlenning! Merged.

avatar Kubik-Rubik Kubik-Rubik - reference | 1cfaf5a - 24 Oct 15
avatar Kubik-Rubik Kubik-Rubik - merge - 24 Oct 2015
avatar Kubik-Rubik Kubik-Rubik - close - 24 Oct 2015
avatar Kubik-Rubik Kubik-Rubik - change - 24 Oct 2015
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-10-24 10:28:31
Closed_By ⇒ Kubik-Rubik
avatar Kubik-Rubik Kubik-Rubik - close - 24 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - close - 24 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - change - 24 Oct 2015
Labels Removed: ?
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone

Add a Comment

Login with GitHub to post a comment