? Pending

User tests: Successful: Unsuccessful:

avatar ITPrism
ITPrism
27 Sep 2015

The method toInteger() returns converted array.

avatar ITPrism ITPrism - open - 27 Sep 2015
avatar ITPrism ITPrism - change - 27 Sep 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Sep 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 28 Sep 2015
Category Administration
avatar pos-it pos-it - test_item - 24 Oct 2015 - Tested successfully
avatar pos-it
pos-it - comment - 24 Oct 2015

I have tested this item :white_check_mark: successfully on 9738eb6

Could not realy find a way to test it with the Application itself.
So I write some lines before the if statment to test the method.
Basically without the Patch the old line has no effect at all because the new Helper class do not accept a variable as reference.
So only with the Patch $categoryId will be converted int an array of Integers if needed


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7952.

avatar waader
waader - comment - 24 Oct 2015

In line 264 I assigned an array to $categoryId like @pos-it described and I get the same results. When I add a string to the array I get an sql error without the patch applied.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7952.

avatar Bakual
Bakual - comment - 24 Oct 2015

Merging based on review and single test. Thanks!

avatar Bakual Bakual - change - 24 Oct 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-10-24 18:05:56
Closed_By Bakual
avatar Bakual Bakual - close - 24 Oct 2015
avatar Bakual Bakual - reference | c9019cc - 24 Oct 15
avatar Bakual Bakual - merge - 24 Oct 2015
avatar Bakual Bakual - close - 24 Oct 2015
avatar zero-24 zero-24 - change - 24 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone

Add a Comment

Login with GitHub to post a comment