[#7950] - Ensure public JHtml helpers can be overridden
- Closed
- 30 Oct 2015
- Medium
- Build: staging
- Easy Test
- # 7950
- Diff
- mbabker:JHtml-overrides
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This patch does a review on the uses of JHtml helpers in the libraries folder and ensures that most public facing methods are called through the JHtml::_() method to allow them to be overridden using the JHtml API.
Summary of Change
- Calls to
static::method()in JHtml helper classes changed to use theJHtml::_()method call - Calls to certain JHtml methods (script, stylesheet, tooltipText being among the most common offenders) changed to use the
JHtml::_()method call
Testing Instructions
Make sure the CMS still works. This patch touches a lot of files in most every component or JHtml helper.
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
zero-24
- | Easy | No | ⇒ | Yes |
| Category | ⇒ | Libraries |
Without breaking this down into an obscene number of patches, not really. A lot of the changes change the calls for the tooltipText method from JHtml::tooltipText() to JHtml::_('tooltipText'), so one indicator of breakage is that tooltips would not render correctly anymore.
I have tested this item 
successfully on 6ead8f1
All good front end - backend, also Reviewed for typos all good
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7950.
This PR has received new commits.
CC: @dgt41
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7950.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-10-30 18:00:46 |
| Closed_By | ⇒ | mbabker |
is there a better instruction to test it? "If the CMS still works" is too global IMO ;-)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7950.