? Success

User tests: Successful: Unsuccessful:

avatar Mathewlenning
Mathewlenning
25 Sep 2015

Removed redundant Else statement from __get method

avatar Mathewlenning Mathewlenning - open - 25 Sep 2015
avatar Mathewlenning Mathewlenning - change - 25 Sep 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Sep 2015
Labels Added: ?
avatar mbabker
mbabker - comment - 25 Sep 2015

I don't think trigger_error causes a return so you'd still end up getting back $this->type regardless of the requested value in this case. So it should probably be the if statement like it was before and the trigger_error be after the if statement.

avatar wilsonge wilsonge - change - 25 Sep 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-09-25 16:07:37
Closed_By wilsonge
avatar wilsonge wilsonge - close - 25 Sep 2015
avatar wilsonge wilsonge - reference | 7b7a361 - 25 Sep 15
avatar wilsonge wilsonge - merge - 25 Sep 2015
avatar wilsonge wilsonge - close - 25 Sep 2015
avatar wilsonge wilsonge - change - 25 Sep 2015
Milestone Added:
avatar Mathewlenning Mathewlenning - head_ref_deleted - 28 Sep 2015
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone

Add a Comment

Login with GitHub to post a comment