[#7941] - Show a message in the installer regarding PHP version support
- Closed
- 30 Oct 2015
- Medium
- Build: 3.5-dev
- Easy Test
- # 7941
- Diff
- mbabker:php-version-alert
- Pending Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
This PR adds an alert to the "Finalisation" page in the installer if the active PHP version is either no longer supported by the PHP project or is only receiving security fixes. This is intended to inform users of the support status of their chosen PHP version and provide them with the data to make an informed upgrade decision.
Test Instructions
You'll need to either download my php-version-alert branch from GitHub or patch your git clone of the CMS repository. Once applied, run through the installer and when reaching the final page, you should see an alert similar to the below screenshots if you are running PHP 5.5 or earlier. No alert is rendered for fully supported versions or versions we do not have support data for (i.e. the 7.0 release candidates).
Maintenance Requirements
The InstallationModelSetup::getPhpSupport() method will need to be updated with new releases (approximately once a year) or if support dates for a version change. This data should be acquired from PHP.net.
Screenshots:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
I hesitate to make it an alert-error div because that might imply the install hit a fatal error. Likewise with the default warning class, just not a fatal error necessarily. I think the info class is appropriate in this case to convey information.
I think it would be enhanced if we added a message similar to the magic
quotes message "please contact your host for more information how to update
your php version"
Otherwise the forum is flooded with advice how to do it which may or may
not work dependent on the host.
Also as its a message to users should it not be for all users ie not just
on new installs. Perhaps a dismissable message in the admin control panel.
On 24 Sep 2015 4:06 pm, "Michael Babker" notifications@github.com wrote:
I hesitate to make it an alert-error div because that might imply the
install hit a fatal error. Likewise with the default warning class, just
not a fatal error necessarily. I think the info class is appropriate in
this case to convey information.—
Reply to this email directly or view it on GitHub
#7941 (comment).
If we do an admin message I'd use the post install messages for that
personally, but yes it could be appropriate to add something there too.
And the message text can definitely be improved.
FWIW we did this same thing in another OSS project with only the alert in
our installer. Whether it's coincidence or the message nudging users,
we've seen almost a 3% drop in PHP 5.3 use rates since the release with
that message and almost a similar climb for 5.6.
On Thursday, September 24, 2015, Brian Teeman notifications@github.com
wrote:
I think it would be enhanced if we added a message similar to the magic
quotes message "please contact your host for more information how to update
your php version"Otherwise the forum is flooded with advice how to do it which may or may
not work dependent on the host.Also as its a message to users should it not be for all users ie not just
on new installs. Perhaps a dismissable message in the admin control panel.
On 24 Sep 2015 4:06 pm, "Michael Babker" > wrote:I hesitate to make it an alert-error div because that might imply the
install hit a fatal error. Likewise with the default warning class, just
not a fatal error necessarily. I think the info class is appropriate in
this case to convey information.—
Reply to this email directly or view it on GitHub
#7941 (comment).—
Reply to this email directly or view it on GitHub
#7941 (comment).
To be fair that project would be 99% new installs.
On 24 Sep 2015 4:19 pm, "Michael Babker" notifications@github.com wrote:
If we do an admin message I'd use the post install messages for that
personally, but yes it could be appropriate to add something there too.
And the message text can definitely be improved.FWIW we did this same thing in another OSS project with only the alert in
our installer. Whether it's coincidence or the message nudging users,
we've seen almost a 3% drop in PHP 5.3 use rates since the release with
that message and almost a similar climb for 5.6.On Thursday, September 24, 2015, Brian Teeman notifications@github.com
wrote:I think it would be enhanced if we added a message similar to the magic
quotes message "please contact your host for more information how to
update
your php version"Otherwise the forum is flooded with advice how to do it which may or may
not work dependent on the host.Also as its a message to users should it not be for all users ie not just
on new installs. Perhaps a dismissable message in the admin control
panel.
On 24 Sep 2015 4:06 pm, "Michael Babker" > wrote:I hesitate to make it an alert-error div because that might imply the
install hit a fatal error. Likewise with the default warning class,
just
not a fatal error necessarily. I think the info class is appropriate in
this case to convey information.—
Reply to this email directly or view it on GitHub
<#7941 (comment)
.—
Reply to this email directly or view it on GitHub
#7941 (comment).—
Reply to this email directly or view it on GitHub
#7941 (comment).
looks good.
Will the JOOMLA_MINIMUM_PHP also be changed in J3.5?
No.
zero-24
- | Category | ⇒ | Installation |
| Easy | No | ⇒ | Yes |
Please also patch en-US, en-AU and en-CA
Message is updated with "contact host" string. A message in the admin UI will be a separate PR.
I have tested this item 
successfully on 4f3e0f4
It works. Perfect.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7941.
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-10-30 18:00:46 |
| Closed_By | ⇒ | mbabker |
| Milestone |
Removed: |
||
Like it! (hnot tested yet)
Question: shouldn't we rather use 'alert-error' or at least 'alert-info' class for the EOL versions?