? Success

User tests: Successful: Unsuccessful:

avatar bertmert
bertmert
24 Sep 2015

It's not possible to save HTML in description fields.

The issue was reported at german forum by user fexes
http://forum.joomla.de/index.php/Thread/818-HTML-Tags-in-Login-Beschreibungstext/?postID=5531#post5531
and I was asked to create a PR by another user.

  • Add new menu item of type Users > Login Form.
  • In tab Options enter HTML text in fields Login Description Text and Logout Description Text:
<p>Some text.</p>
<p>Some more text.</p>
  • Save menu item.
  • HTML tags are away.
  • Apply patch.
  • Try again.
  • HTML tags kept.

This is the old behavior known from Joomla 1.5. (Joomla 2.5? I don't know).

avatar bertmert bertmert - open - 24 Sep 2015
avatar bertmert bertmert - change - 24 Sep 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Sep 2015
Labels Added: ?
avatar Bakual
Bakual - comment - 24 Sep 2015

Fine with me. We do the same thing for the "Site Offline" message.

avatar Bakual Bakual - change - 24 Sep 2015
Milestone Added:
avatar bertmert
bertmert - comment - 24 Sep 2015

Offline message: There we have already a filter="safehtml"

avatar Bakual
Bakual - comment - 24 Sep 2015

Offline message: There we have already a filter="safehtml"

That's what I meant, yes :smile:

avatar zero-24 zero-24 - change - 24 Sep 2015
Easy No Yes
avatar zero-24 zero-24 - change - 24 Sep 2015
Category UI/UX
avatar astridx
astridx - comment - 24 Sep 2015

I add a new menu item of type Users>Login Form and I put all these tags in the description field: https://github.com/cbracco/html5-test-page
After applying the patch all tags are kept.

avatar astridx astridx - test_item - 24 Sep 2015 - Tested successfully
avatar zero-24 zero-24 - test_item - 1 Oct 2015 - Tested successfully
avatar zero-24
zero-24 - comment - 1 Oct 2015

I have tested this item :white_check_mark: successfully on 736c807
Works as expected thanks @bertmert


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7939.

avatar zero-24 zero-24 - change - 1 Oct 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 1 Oct 2015

RTC now thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7939.

avatar joomla-cms-bot joomla-cms-bot - change - 1 Oct 2015
Labels Added: ?
avatar zero-24 zero-24 - alter_testresult - 2 Oct 2015 - astridx: Tested successfully
avatar rdeutz rdeutz - change - 2 Oct 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-10-02 11:48:09
Closed_By rdeutz
avatar rdeutz rdeutz - close - 2 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - close - 2 Oct 2015
avatar rdeutz rdeutz - reference | dd10eb5 - 2 Oct 15
avatar rdeutz rdeutz - merge - 2 Oct 2015
avatar rdeutz rdeutz - close - 2 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - change - 2 Oct 2015
Labels Removed: ?
avatar supergrug
supergrug - comment - 3 Oct 2015

Hi - good timing as I just came across this limitation and would like to add some links to the 'login description text' on my J3.4.4 site. I'm new to GitHub but wonder if someone could explain to me which file/s in J3.4.4 need to be modified using the modifications as described in this thread to get basic HTML tags to work? And where can I view the code modifications?

Also when J3.4.5 is made available, how do I know if the changes will be included in the public distribution, and hence overwrite my joomla core hacks (which is fine so long as the functionality is retained etc).

avatar zero-24
zero-24 - comment - 3 Oct 2015
avatar rdeutz
rdeutz - comment - 3 Oct 2015

There is a file changed tab above, but this might work in this case but sometime PR rely on other PR and you can't see what is needed to make it work. I would suggest not to hack the core and just wait or create a template override.

avatar supergrug
supergrug - comment - 3 Oct 2015

@rdeutz @zero-24 Thanks for the very speedy replies. So I went into the Template manager and created a template override for com_users/login, which was copied to /templates/yoo_peak/html/com_users/login. First time I've done this so it might be expected behaviour, but the default.xml file didn't copy across into this directory, just the other three php files from the /components/com_users/views/login/tmpl/ folder. As the .xml file is the one I need to modify, I manually copied that out of the core into the override, made the changes as suggested in this thread, but the HTML code is still being stripped out. So I'm figuring that the override, being in the front end template, doesn't have any impact on the back end of Joomla? Is there such a thing as a back end override, or in this instance is a core modification necessary?

avatar bertmert
bertmert - comment - 3 Oct 2015

@supergrug
Change the core file directly. As changes are merged already for J3.4.5 that's OK.

(You can create an additional menu item via template override but that needs some more steps, some more changes in xml and needs renaming of files in the override. I think you don't want that.)

avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone

Add a Comment

Login with GitHub to post a comment