[#7925] - Reimplementing CPanel modules automatic title (fix for https://github.com/joomla/joomla-cms/issues/7917 )
- Closed
- 1 Oct 2015
- Medium
- Build: staging
- Easy Test
- # 7925
- Diff
- infograf768:automaticmoduletitle
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
No idea why, but the automatic title used in 2.5 for the CPanel modules (Logged users, Popular articles and Latest articles) was taken off from version 3.x on. See #7917
The strings have remained in core. The code exists in each module helper. Just remained to add the field in the xmls and the code in JModuleHelper.
This is what we now get after patch IF the Automatic Title parameter is set to Yes for these modules in their Advanced tab.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Administration Libraries Modules |
I just put it there for reference. I don't mind it being in our not. Never missed it myself but obviously it was missed by some 
| Status | Pending | ⇒ | Ready to Commit |
| Easy | No | ⇒ | Yes |
2 good tests. RTC.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7925.
| Labels |
Added:
?
|
||
Can we document this feature somewhere? Because it's quite unintuitive at the moment.
Modules need to implement a parameter "automatic_title" if they want to use it. And then optionally create a getTitle method in the properly named helper or add a language string.
Currently, it's an additional one of the many undocumented features our CMS has. We should really either make the features more obvious to developers and/or document them better.
Currently, it's an additional one of the many undocumented features our CMS has. We should really either make the features more obvious to developers and/or document them better.
Agree, no idea though how to do that.
One idea would be to change the code so it always looks for a getTitle method in the helper. If it exists, fire it and if it returns any string, use that as $module->title.
Then that method can check a param itself and can decide if it wants to use a language string or whatever. Then all we need to document is that the helper can have an optional getTitle method.
That would actually be easy understandable by any dev looking at a module that implements it and it can be added to the docs wiki (eg https://docs.joomla.org/J3.x:Creating_a_simple_module).
dgt41
- 
zero-24
- | Milestone |
Added: |
||
I wouldn't remove it, just deprecate the method, and maybe if you want add a JLog message.
In theory that method could be used by a layout override. Not very likely but there is no reason to remove the method when we can properly deprecate it. It can be removed with 4.0.
I will let a specialist do that :)
See infograf768#23
done
rdeutz
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-10-01 18:43:52 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
| Milestone | |||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone | |||
This feature was removed with e11117d.
It was previously done in the cpanel layout (https://github.com/joomla/joomla-cms/blob/544add4880417c586c2ca1b60b60c2fae7b63513/administrator/components/com_cpanel/views/cpanel/tmpl/default.php) itself and wasn't a globally available feature.