?

Success

User tests: Successful: Unsuccessful:

avatar proweb
proweb
20 Sep 2015

We have setHtml5 function in core
Why we aren't use it in default template? It's 2016 year on yard...

Votes

# of Users Experiencing Issue
0/1
Average Importance Score
3.00

avatar proweb proweb - open - 20 Sep 2015
avatar proweb proweb - change - 20 Sep 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Sep 2015
Labels Added: ?
avatar Bakual
Bakual - comment - 20 Sep 2015

What is the purpose of that method? Afaik the page is served as HTML5 anyway due to the doctype, or not?

avatar proweb
proweb - comment - 20 Sep 2015

Yes, due to the doctype is served.
But scripts and css - not.
You can see the difference(Protostar template ):

setHtml5 is not set

image

setHtml5 is set

image

As you can see with setHtml5 all js and css have no `type="text/javascript", http-equiv="content-type" disappear and only charset stay as should be in HTML5 document by W3ะก standart.

avatar Bakual
Bakual - comment - 20 Sep 2015

I see. Are there any B/C issues with that? Like does IE8 fully support this?
Check https://docs.joomla.org/Joomla_Browser_Support, it has to work with all of those.
Since validator.w3.org does show an error, I guess the current way is also allowed in HTML5?

avatar infograf768
infograf768 - comment - 21 Sep 2015
avatar zero-24 zero-24 - change - 23 Sep 2015
Category Templates (site)
avatar seagul30 seagul30 - test_item - 24 Oct 2015 - Tested successfully
avatar seagul30
seagul30 - comment - 24 Oct 2015

I have tested this item :white_check_mark: successfully on 89e30f4

tested in FF and compared all pages to IE8. There were no differences with or without patch. Only breadcrumbs in IE8 looks different, but this is also without patch.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7915.

avatar waader waader - test_item - 24 Oct 2015 - Tested successfully
avatar waader
waader - comment - 24 Oct 2015

I have tested this item :white_check_mark: successfully on 89e30f4

I also tested this with IE8 and could not find a B/C issue. Breadcrumbs are indeed cluttered, but it has nothing to do with this patch.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7915.

avatar zero-24 zero-24 - change - 24 Oct 2015
Milestone Added:
Status Pending Ready to Commit
avatar zero-24 zero-24 - change - 24 Oct 2015
Milestone Added:
avatar zero-24
zero-24 - comment - 24 Oct 2015

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7915.

avatar joomla-cms-bot joomla-cms-bot - change - 24 Oct 2015
Labels Added: ?
avatar wojsmol
wojsmol - comment - 25 Oct 2015
avatar rdeutz
rdeutz - comment - 25 Oct 2015

you need to push this to your branch, then it end in this PR and all is good and we can merge it

avatar wojsmol
wojsmol - comment - 25 Oct 2015

@rdeutz The last comment was directed to me?

avatar rdeutz
rdeutz - comment - 25 Oct 2015

@wojsmol no really, it was advice for @proweb

avatar wojsmol
wojsmol - comment - 25 Oct 2015

@rdeutz My PR against @proweb branch solves this problem.I am waiting for @proweb acceptance (proweb#1) :smile:

avatar joomla-cms-bot
joomla-cms-bot - comment - 26 Oct 2015

This PR has received new commits.

CC: @seagul30, @waader


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7915.

avatar proweb
proweb - comment - 26 Oct 2015

@rdeutz @wojsmol merged you PR

avatar rdeutz rdeutz - reference | 09850c2 - 26 Oct 15
avatar rdeutz rdeutz - merge - 26 Oct 2015
avatar rdeutz rdeutz - close - 26 Oct 2015
avatar rdeutz rdeutz - change - 26 Oct 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-10-26 07:26:11
Closed_By rdeutz
avatar rdeutz rdeutz - close - 26 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - close - 26 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - change - 26 Oct 2015
Labels Removed: ?
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone

Add a Comment

Login with GitHub to post a comment