Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#7911] - Directly set $feed_email in configuration.php created during installation

? Success

User tests: Successful: Unsuccessful:

avatar wojsmol
wojsmol
19 Sep 2015

Hello
IMHO configuration.php created during the installation should not differ as to set the value of this created after saving the global settings without making any changes immediately after installation. This PR sets a the default setting that display RSS email address = author. If PR #7411 by @pe7er to be approved before my then this PR will need to be adjusted.

avatar wojsmol wojsmol - open - 19 Sep 2015
avatar wojsmol wojsmol - change - 19 Sep 2015
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Sep 2015
Labels Added: ?
avatar zero-24
zero-24 - comment - 19 Sep 2015

@wojsmol here is just a CS fix that removes the whitespace: wojsmol#1

avatar zero-24 zero-24 - change - 19 Sep 2015
Category ⇒ Installation
avatar zero-24 zero-24 - change - 19 Sep 2015
Easy No ⇒ Yes
avatar wojsmol
wojsmol - comment - 19 Sep 2015

@zero-24 CS PR marged

avatar farrelljsec farrelljsec - test_item - 24 Oct 2015 - Tested successfully
avatar farrelljsec
farrelljsec - comment - 24 Oct 2015

I have tested this item :white_check_mark: successfully on b71eeb2

It works, but not good to show the author email address.
Better would be: public $ feed_email = 'none';

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7911.

avatar zero-24
zero-24 - comment - 24 Oct 2015

@wojsmol can you implement the suggestion by @farrelljsec ? If that is done please ping me so i can do the seccond test :smile: Thanks.

avatar joomla-cms-bot
joomla-cms-bot - comment - 24 Oct 2015

This PR has received new commits.

CC: @farrelljsec

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7911.

avatar wojsmol
wojsmol - comment - 24 Oct 2015

@zero-24 change made, @farrelljsec thanks for testing :smile:

avatar zero-24 zero-24 - alter_testresult - 24 Oct 2015 - farrelljsec: Tested successfully
avatar zero-24 zero-24 - test_item - 24 Oct 2015 - Tested successfully
avatar zero-24
zero-24 - comment - 24 Oct 2015

I have tested this item :white_check_mark: successfully on fd462bc

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7911.

avatar zero-24 zero-24 - change - 24 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 24 Oct 2015
Milestone Added:
Status Pending ⇒ Ready to Commit
avatar zero-24
zero-24 - comment - 24 Oct 2015

Just alterd @farrelljsec test as we just implement the suggestion and add my test. So we are complete to RTC. Thanks :smiley:

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7911.

avatar joomla-cms-bot joomla-cms-bot - change - 24 Oct 2015
Labels Added: ?
avatar rdeutz rdeutz - reference | 5b53369 - 25 Oct 15
avatar rdeutz rdeutz - merge - 25 Oct 2015
avatar rdeutz rdeutz - close - 25 Oct 2015
avatar rdeutz rdeutz - change - 25 Oct 2015
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-10-25 10:23:11
Closed_By ⇒ rdeutz
avatar rdeutz rdeutz - close - 25 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - close - 25 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - change - 25 Oct 2015
Labels Removed: ?
avatar wojsmol wojsmol - head_ref_deleted - 25 Oct 2015
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone

Add a Comment

Login with GitHub to post a comment