[#7902] - Fix https base tag generation.
- Closed
- 2 Oct 2015
- Medium
- Build: staging
- Easy Test
- # 7902
- Diff
- wojsmol:fixbasetag
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Hallo
This PR replaces #6270 by @GregoryRusakov and is based on code proposed by @nonumber in #6270 (comment) .
A copy of the original PR description
Fixed https base tag generation.
Discussion is here:
#4961 (comment)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
@GregoryRusakov Please mark your test results on http://issues.joomla.org/tracker/joomla-cms/7902
zero-24
- | Category | ⇒ | Libraries |
| Easy | No | ⇒ | Yes |
@GregoryRusakov Thank you for the test, @zero-24 already mark the result on http://issues.joomla.org/tracker/joomla-cms/7902. We need one more tester.
Hello - Can you please explain the test so I can validate?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7902.
Hi folks,
I have strong doubts about this PR. Using JUri::base() is not the definition of the tag. Such change will break all hardcoded relative URL in a page, the most common being the named anchors such as <a href="#top">Go to top</a> or similar.
The initial PR (#6270) discussion doesn't seem conclusive to me, as base tag is properly set on my https sites with current Joomla. Regardless, this PR will break many sites.
Rgds
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-10-02 08:28:44 |
| Closed_By | ⇒ | wojsmol |
Hello,
Access to the website is organized on next schema:
Front (Nginx) -> Middle (Varnish) -> Back (Apache). Interaction with Middle and Back from Front side executes via http for better performance.
So, this PR is still actual.
The patch works, but as @weeblr said, it affect anchors. So, we need another solution that let Joomla to work with Varnish correctly. Is there any idea?
The problem is still actual.
Could you provide the steps to recreate the issue with the existing code and explain why the issue occurs.
And the steps to recreate when and why the fix proposed would work, and not work.
Everything is ok.