[#7894] - Improvements for mod_finder layout
- Closed
- 24 Oct 2015
- Medium
- Build: staging
- Easy Test
- # 7894
- Diff
- mbabker:mod_finder-updates
- Success Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of changes:
- Adds a placeholder to the
<input>element with the default search value - Removes JavaScript to "fake" this placeholder
- Always renders the input's label and applies the
element-invisibleclass if the label is hidden (same class is in use, and hardcoded in fact, in the mod_search layout) - Change call to
JHtml::stylesheet()to use theJHtml::_()method
Test Instructions:
Make sure the module still functions correctly (layout as designed, label has the element-invisible class if supposed to be hidden, autocompletion still works)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
The templates load it, we don't have a JHtml endpoint for it.
Oh ok my bad :)
| Easy | No | ⇒ | Yes |
| Category | ⇒ | Modules |
Does not work under Win 10 / MS browser Edge
page is displayed in white
I have tested this item 
successfully on 502a1f2
Tested successfully.
Joomla 3.4.5
Chrome
Safari
Firefox
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7894.
@test successful in 3.4.5 (win10)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7894.
additional info: Win 10 / MS browser Edge and Firefox
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7894.
I have tested this item successfully on 502a1f2
@text successfully testet.
I missing the possibility to change the placeholder value in backend.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7894.
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-10-24 13:30:31 |
| Closed_By | ⇒ | Kubik-Rubik |
| Labels |
Removed:
?
|
||
@KlausKrippeit You can change it as a language override, the placeholder uses the MOD_FINDER_SEARCH_VALUE key. Unfortunately because of how some of the internal JavaScript is coded it isn't practical to add an option to the module to change it right now.
| Milestone | |||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone | |||
As techincally we are supporting IE8 which doesn't have placeholder support I guess we should load HTML5 Shiv now?