[#7879] - Update en-GB.com_finder.ini
- Closed
- 16 May 2016
- Medium
- Build: staging
- # 7879
- Diff
- aaleksanyants:patch-10
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 3 Successful 1 Failed. Details
User tests: Successful: Unsuccessful:
"Filter New" means "Filter new items", while the command is for new filter creation. Also chaged "Filter Edit" to "Edit Filter" to make them looking similar.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
LOL, indeed
| Category | ⇒ | Language & Strings |
I have tested this item 
successfully on fa176d8
In component smart search the title has changed after applying the patch
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7879.
@aaleksanyants can you have a look at comments by @infograf768 and @sovainfo so we can get this in? Thanks @Wilma999 for your test 
Thanks for notifying, I am OK with the suggestions by @infograf768 and @sovainfo, however I cannot know if why the title has chaged after applying the patch as @Wilma999 reports.
I have tested this item 
unsuccessfully on fa176d8
In every component the text is different.
Category Manager: Add A New Contacts Category
Tags: New
I do think the text should be the menu-path to the item.
In this case:
Smart Search - Search Filters - New
Maybe it is a good idea to check all the texts, decide what to use and implement it that way
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7879.
I have tested this item successfully on fa176d8
I understand @MartijnMaandag but I agree with this PR
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7879.
@aaleksanyants If you merge my PR aaleksanyants#4 then the sort order will be good and then this can be merged
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7879.
I have tested this item successfully on fa176d8
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7879.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Pending |
| Labels | |||
| Milestone |
Removed: |
||
Ooops Removed RTC still waiting for my patch to reorder the strings to be merged
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7879.
| Labels |
Removed:
?
|
||
it has not been alpha ordered yet.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-16 08:25:48 |
| Closed_By | ⇒ | brianteeman | |
| Labels | |||
| Labels | |||
No point waiting any longer - I have made a new PR with these edits and alpha ordered see #10513
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7879.
In case of alpha sort it should be:
COM_FINDER_FILTER_MAP_COUNT="Nombre de plans"
COM_FINDER_FILTER_NEW_TOOLBAR_TITLE="Recherche avancée : Nouveau filtre"