?
avatar raabigramm
raabigramm
13 Sep 2015

Hi all,

in hide.js there's a bug in line 268 so that Openmenu does not get translated:

    $mobile = $('<div>', {id: 'mobile_select'}).html('<h2><a href=#" id="menuopener" onclick="return false;"><span>Openmenu</span></a></h2>').show();

The correct version is as follows:

    $mobile = $('<div>', {id: 'mobile_select'}).html('<h2><a href=#" id="menuopener" onclick="return false;"><span>'+Openmenu+'</span></a></h2>').show();

Thank you for including it to the sources.

Bye, Roland

avatar raabigramm raabigramm - open - 13 Sep 2015
avatar Kubik-Rubik
Kubik-Rubik - comment - 13 Sep 2015

@raabigramm Please create a Pull Request with your suggested change. Thank you!

avatar raabigramm
raabigramm - comment - 13 Sep 2015

Hi,

I'm sorry but I don't know how. I am confused since I'll have to compare versions first...

Bye, Roland

avatar n9iels
n9iels - comment - 13 Sep 2015

You can use this documentation to make a Pull Request:
https://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests

avatar infograf768 infograf768 - change - 14 Sep 2015
Status New Closed
Closed_Date 0000-00-00 00:00:00 2015-09-14 08:53:48
Closed_By infograf768
avatar joomla-cms-bot joomla-cms-bot - close - 14 Sep 2015
avatar infograf768
infograf768 - comment - 14 Sep 2015
avatar joomla-cms-bot joomla-cms-bot - close - 14 Sep 2015
avatar zero-24 zero-24 - close - 14 Sep 2015
avatar infograf768
infograf768 - comment - 14 Sep 2015

PR is here: #7873

Closing the issue


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7872.

avatar zero-24 zero-24 - change - 17 Sep 2015
Labels Added: ?

Add a Comment

Login with GitHub to post a comment