? Success

User tests: Successful: Unsuccessful:

avatar izharaazmi
izharaazmi
11 Sep 2015

Removed unused variable $user.
Variables $historyTable and $rowArray were used outside the IF body where they weren't defined.

To test this call the JModelLegacy::loadHistory with $version_id = 0 with and without this fix.

avatar izharaazmi izharaazmi - open - 11 Sep 2015
avatar izharaazmi izharaazmi - change - 11 Sep 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Sep 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 17 Sep 2015
Category Libraries
avatar zero-24 zero-24 - change - 17 Sep 2015
Easy No Yes
avatar zero-24 zero-24 - change - 20 Oct 2015
Easy Yes No
avatar PhocaCz PhocaCz - test_item - 24 Oct 2015 - Tested successfully
avatar PhocaCz
PhocaCz - comment - 24 Oct 2015

I have tested this item :white_check_mark: successfully on f836160

Hi, testing now the patch and seems:

  • it works
  • and it repairs the problems mentioned above.

Jan


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7860.

avatar matrikular matrikular - test_item - 24 Oct 2015 - Tested successfully
avatar matrikular
matrikular - comment - 24 Oct 2015

I have tested this item :white_check_mark: successfully on f836160

Patch solves issue.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7860.

avatar zero-24 zero-24 - change - 24 Oct 2015
Milestone Added:
Status Pending Ready to Commit
avatar zero-24 zero-24 - change - 24 Oct 2015
Milestone Added:
avatar zero-24
zero-24 - comment - 24 Oct 2015

RTC for 3.4.6. Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7860.

avatar joomla-cms-bot joomla-cms-bot - change - 24 Oct 2015
Labels Added: ?
avatar rdeutz rdeutz - change - 24 Oct 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-10-24 14:29:24
Closed_By rdeutz
avatar rdeutz rdeutz - close - 24 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - close - 24 Oct 2015
avatar rdeutz rdeutz - reference | d0b9c65 - 24 Oct 15
avatar rdeutz rdeutz - merge - 24 Oct 2015
avatar rdeutz rdeutz - close - 24 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - change - 24 Oct 2015
Labels Removed: ?
avatar izharaazmi izharaazmi - head_ref_deleted - 24 Oct 2015
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone

Add a Comment

Login with GitHub to post a comment