Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#7849] - Make sure $value parameter passed to JHtml::calendar method is valid

? Success
Pull Request for # 7846

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
9 Sep 2015

This PR fixed the issue #7846. It just add a check to make sure the value passed to JHtml::calendar method is valid.

In case the value is invalid, instead of throwing exception at the moment, it will reset the value to be empty and prevent the error above from happening.

Testing instructions

JHml::calendar is used in many places in Joomla core. To test this, you can try to edit an article, look at Publishing tab, make sure the calendar inputs such as Start Publishing, Created Date... stil display the correct value.

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
3.00
avatar joomdonation joomdonation - open - 9 Sep 2015
avatar joomdonation joomdonation - change - 9 Sep 2015
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Sep 2015
Labels Added: ?
avatar joomdonation joomdonation - change - 9 Sep 2015
Title
…
Make sure $value passed to the method is valid
Make sure $value parameter passed to JHtml::calendar method is valid
avatar Bakual
Bakual - comment - 10 Sep 2015

Can you revert the changes with line indent?

avatar joomdonation
joomdonation - comment - 10 Sep 2015

Seems the line indent added by the editor I am using. I just removed it, should be OK now.

avatar Bakual
Bakual - comment - 10 Sep 2015

Looks much better now, thanks!

avatar zero-24 zero-24 - change - 17 Sep 2015
Category ⇒ Libraries
avatar zero-24 zero-24 - change - 17 Sep 2015
Rel_Number 0 ⇒ 7846
Relation Type ⇒ Pull Request for
Easy No ⇒ Yes
avatar nicksavov nicksavov - test_item - 21 Sep 2015 - Tested successfully
avatar nicksavov
nicksavov - comment - 21 Sep 2015

I tested it and it works well for me. It resolves issue OSTraining/OSContent#57

avatar nicksavov
nicksavov - comment - 21 Sep 2015

@htmgarcia also tested it and it resolved the issue for him.

avatar zero-24 zero-24 - alter_testresult - 23 Sep 2015 - htmgarcia: Tested successfully
avatar zero-24 zero-24 - change - 23 Sep 2015
Status Pending ⇒ Ready to Commit
avatar zero-24
zero-24 - comment - 23 Sep 2015

RTC based on tests thanks @nicksavov @htmgarcia and @joomdonation !

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7849.

avatar joomla-cms-bot joomla-cms-bot - change - 23 Sep 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 23 Sep 2015
Milestone Added:
avatar rdeutz rdeutz - change - 1 Oct 2015
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-10-01 18:28:26
Closed_By ⇒ rdeutz
avatar rdeutz rdeutz - close - 1 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - close - 1 Oct 2015
avatar rdeutz rdeutz - reference | eac18c5 - 1 Oct 15
avatar rdeutz rdeutz - merge - 1 Oct 2015
avatar rdeutz rdeutz - close - 1 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - change - 1 Oct 2015
Labels Removed: ?
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone
avatar joomdonation joomdonation - head_ref_deleted - 19 Dec 2015
avatar ymsstudios
ymsstudios - comment - 28 Jan 2016

Thanks guys I used your update and it worked great for me!

Add a Comment

Login with GitHub to post a comment