[#7833] - Remove readonly on input element, increase size
- Closed
- 17 Oct 2015
- Medium
- Build: staging
- Easy Test
- # 7833
- Diff
- ryandemmer:patch-3
- Success Human Test Results: 4 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
This change increases the size of the input element by changing the input-small class to input-large, and removes the readonly="readonly" attribute on the input element.
This allows the user to enter in a value into the field, or select a value using the modal as before.
Testing:
After applying the changes, create or edit an article using the Article Manager, then click on the Images and Links tab. The Intro Image and Full Text Image fields should be larger and a value can be typed/pasted into the field.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Libraries |
| Easy | No | ⇒ | Yes |
I guess, if we let people type something in that field, we need to validate that input (js validation).
We let users type in the image path manually when using the image editor plugin. Do we validate it here?
Good question, let me check
tested and works as expected
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7833.
pending the answer to Brian's question, another successful test here.
Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7833.
I've got a hacked up custom copy of this field in my code and no there aren't any validations on the image URL field that I had to work around to remove the readonly attribute.
@brianteeman you are right, no javascript validation on those fields
@mbabker on the server side I guess we are ok as the field will be filtered as any other text field.
My initial idea was to write a simple validation script that will check if the (relative/absolute) path/filename.extension is acceptable.
@test ok here as well
| Status | Pending | ⇒ | Ready to Commit |
@joomla-cms-bot Again an example here. @dgt41 is also part of the CMS Maintainers and the Joomla Bug Squad. If he set a Pull Request to RTC you can add the label without problem. 
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7833.
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
rdeutz
- | Milestone |
Added: |
||
| Milestone |
Removed: |
||
Thanks @ryandemmer Merged into 3.5-dev with commit 19419d
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-10-17 09:00:58 |
| Closed_By | ⇒ | roland-d |
| Labels |
Removed:
?
|
||
@test tested and looks and works nice
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7833.