Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#7827] - Reverse if/else logic to return early on negative check

? Success

User tests: Successful: Unsuccessful:

avatar nonumber
nonumber
6 Sep 2015

Checks if module ISN'T published and returns early, instead of having the 'green' code encapsulated in an if.

avatar nonumber nonumber - open - 6 Sep 2015
avatar nonumber nonumber - change - 6 Sep 2015
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Sep 2015
Labels Added: ?
avatar rdeutz
rdeutz - comment - 6 Sep 2015

Please provide at least test instructions for a before and after patch check. Here I think you have changed how the code works, your early returns skip the switch so exceptions doesn't get logged aso. see original file https://github.com/joomla/joomla-cms/blob/staging/components/com_ajax/ajax.php#L171

avatar nonumber nonumber - close - 6 Sep 2015
avatar nonumber nonumber - change - 6 Sep 2015
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-09-06 08:09:02
Closed_By ⇒ nonumber
avatar nonumber nonumber - close - 6 Sep 2015
avatar nonumber nonumber - head_ref_deleted - 27 Oct 2015

Add a Comment

Login with GitHub to post a comment