Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#7817] - Add width and height attributes for modal window

? ? Success

User tests: Successful: Unsuccessful:

avatar ryandemmer
ryandemmer
4 Sep 2015

Add width and height attributes for the modal window with defaults set to the original values of 800 x 500

avatar ryandemmer ryandemmer - open - 4 Sep 2015
avatar ryandemmer ryandemmer - change - 4 Sep 2015
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Sep 2015
Labels Added: ?
avatar n9iels
n9iels - comment - 5 Sep 2015

Can you please add some test instructions so we can test this feature

avatar zero-24 zero-24 - change - 5 Sep 2015
Category ⇒ Libraries
avatar zero-24 zero-24 - change - 5 Sep 2015
Easy No ⇒ Yes
avatar zero-24
zero-24 - comment - 5 Sep 2015

@n9iels

simple testing

1) BE --> Content --> Article --> New Article
2) 'Images & Links' Tab
3) klick on select for the intro image
4) see the pop up.
5) apply the patch
6) repeat 1 to 4 again
7) see it is still the same popup

Advanced testing

1) Step 1-7
2) go to \administrator\components\com_content\models\forms\article.xml arround Line 618
3) replace this:

<field
    name="image_intro"
    type="media"
    label="COM_CONTENT_FIELD_INTRO_LABEL"
    description="COM_CONTENT_FIELD_INTRO_DESC" />

with

<field
    name="image_intro"
    type="media"
    height="200"
    width="200"
    label="COM_CONTENT_FIELD_INTRO_LABEL"
    description="COM_CONTENT_FIELD_INTRO_DESC" />

4) try the same button again
5) see the new higth and width styled pop up.

I have just tested both ways successful. Thanks @ryandemmer

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7817.

avatar zero-24 zero-24 - test_item - 5 Sep 2015 - Tested successfully
avatar MAT978
MAT978 - comment - 8 Sep 2015

Success as able to confirm both simple testing and Advanced testing

Thanks @ryandemmer & Tobias

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7817.

avatar MAT978 MAT978 - test_item - 8 Sep 2015 - Tested successfully
avatar zero-24 zero-24 - change - 8 Sep 2015
Status Pending ⇒ Ready to Commit
avatar zero-24
zero-24 - comment - 8 Sep 2015

Thanks! RTC based on testing.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7817.

avatar joomla-cms-bot joomla-cms-bot - change - 8 Sep 2015
Labels Added: ?
avatar Kubik-Rubik Kubik-Rubik - change - 11 Sep 2015
Milestone Added:
avatar rdeutz rdeutz - change - 1 Oct 2015
Milestone Added:
avatar rdeutz rdeutz - change - 1 Oct 2015
Milestone Removed:
avatar rdeutz rdeutz - change - 1 Oct 2015
Labels Added: ?
avatar rdeutz
rdeutz - comment - 1 Oct 2015

new function because some can set the width and the height of the iframe

avatar roland-d
roland-d - comment - 17 Oct 2015

Thanks @ryandemmer Merged with commit 8c276e into 3.5-dev.

avatar roland-d roland-d - change - 17 Oct 2015
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-10-17 08:49:39
Closed_By ⇒ roland-d
avatar roland-d roland-d - close - 17 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - close - 17 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - change - 17 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment