? Success

User tests: Successful: Unsuccessful:

avatar okonomiyaki3000
okonomiyaki3000
2 Sep 2015

CodeMirror was updated to 5.6. This one includes a new dark theme abcdef.

There are also new addons that I have not included but might be useful.

autorefresh

Deals with the known issue that CodeMirror doesn't render correctly if initially loaded in a hidden part of the page. The Joomla plugin is already dealing with this issue by calling CodeMirror's refresh function whenever one of the shown events is fired so this is not really an issue when using CodeMirror in Joomla. However, this solution only works for specific events (basically, Bootstrap's various shown events) and also uses jQuery. The new addon would solve this issue by polling the editor until it's visible and then refreshing it. This solution will work even if jQuery is not available or Bootstrap is not the reason that the editor was hidden in the first place.

html-lint

Uses HTMLHint to find mistakes in your html code. Personally, I'm a big fan of live-linting. I think this should be included.

Any opinions about either of these addons? I'm most likely going to add them to this PR in the near future unless there is any objection.

avatar okonomiyaki3000 okonomiyaki3000 - open - 2 Sep 2015
avatar okonomiyaki3000 okonomiyaki3000 - change - 2 Sep 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Sep 2015
Labels Added: ?
avatar wilsonge
wilsonge - comment - 2 Sep 2015

I like the idea of both of these plugins - but can we merge this first and then merge the other two as follow up PR's please :)

avatar Kubik-Rubik
Kubik-Rubik - comment - 2 Sep 2015

@okonomiyaki3000 Thank you for the update. Please create a separated PR's for HTMLHint and Autofrefresh.

avatar Kubik-Rubik Kubik-Rubik - change - 2 Sep 2015
Milestone Added:
avatar Kubik-Rubik Kubik-Rubik - change - 2 Sep 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-09-02 13:48:43
Closed_By Kubik-Rubik
avatar Kubik-Rubik Kubik-Rubik - close - 2 Sep 2015
avatar Kubik-Rubik Kubik-Rubik - reference | bc6d2b1 - 2 Sep 15
avatar Kubik-Rubik Kubik-Rubik - merge - 2 Sep 2015
avatar Kubik-Rubik Kubik-Rubik - close - 2 Sep 2015
avatar Kubik-Rubik
Kubik-Rubik - comment - 2 Sep 2015

Thank you @okonomiyaki3000! Merged by code review and comparison with the original files.

Add a Comment

Login with GitHub to post a comment