? Success

User tests: Successful: Unsuccessful:

avatar lecoeurlou
lecoeurlou
30 Aug 2015

This is my first pull request so please bear with me. So I've been using this register function, but I noticed in the code that $model->validate() was called with $data as its only parameter, resulting in a fatal error afterwards.
I grabbed the model form as it is done is other controllers, and added it to the function call.
This fixes it and -I think- respects Joomla's coding guidelines.
P.S. Had to resubmit, I kept spaces in empty lanes before.

avatar lecoeurlou lecoeurlou - open - 30 Aug 2015
avatar lecoeurlou lecoeurlou - change - 30 Aug 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Aug 2015
Labels Added: ?
avatar Bakual
Bakual - comment - 31 Aug 2015

Good catch. This is wrong for sure.
For anyone wondering, this method isn't used in core anymore and should be deprecated.
We use the UsersControllerRegistration->register() method instead.

avatar zero-24 zero-24 - change - 31 Aug 2015
Category Components Front End
avatar wilsonge wilsonge - change - 1 Sep 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-09-01 09:36:15
Closed_By wilsonge
avatar wilsonge wilsonge - close - 1 Sep 2015
avatar wilsonge wilsonge - reference | 4e4ee7a - 1 Sep 15
avatar wilsonge wilsonge - merge - 1 Sep 2015
avatar wilsonge wilsonge - close - 1 Sep 2015
avatar wilsonge wilsonge - change - 1 Sep 2015
Milestone Added:
avatar wilsonge
wilsonge - comment - 1 Sep 2015

Thankyou for the Pull Request :) It's been merged into our staging branch and will be patched in the next Joomla version. We look forward to seeing any future contributions :)

avatar Bakual
Bakual - comment - 29 Oct 2016

Deleted a comment as it was useless and locking conversation as this PR was merged a year ago.

avatar Bakual Bakual - locked - 29 Oct 16

Add a Comment

Login with GitHub to post a comment