@izharaazmi Does this PR need to wait for your fix in joomla-framework/utilities#12 ?

@roland-d No. The fix in joomla-framework/utilities#12 is independent of this PR.

Kindly let me know If there is something awaited from my part.

@izharaazmi Please provide test instructions that touches this code so users can test that nothing is broken. Code review looks good but that is not enough in this case. Thanks.

@roland-d There is no special instruction for this change as I have not made any logical change. No feature added or removed or fixed or improved. The normal tests that applies to JArrayHelper (without this patch) or Joomla\Utilities\ArrayHelper is applicable for this PR as well.
This means the existing unit test cases are well sufficient for this purpose.

However, I might be wrong in saying so, please enlighten me with your perspective.

Please advise if I need to make any changes/improvements to this.
Thanks.

@izharaazmi Finally I had some time to test and the proxies are working fine. Only issue I did find is you changed in the logs the names to FUNCTION and this is not working. The value of FUNCTION is always empty, so I would suggest to revert this change. So your point that the existing unit test cases are sufficient is not correct because they do not test the logging.

To test this issue, you will need to enable debugging mode with XDebug for example to see the changes at work. Editing a category will trigger most changed methods except for the pivot and arrayUnique methods, these are only unit tested.

I have tested this item unsuccessfully on 7f9ff9d

This PR has received new commits.

CC: @roland-d

I just tested the 5 methods in JArrayHelper with object type arguments. I got these lines in my log file. I see the __FUNCTION__ is not empty.

#Fields: datetime   priority clientip   category    message
2015-10-03T08:47:20+00:00   WARNING ::1 deprecated  This method is typehinted to be an array in \Joomla\Utilities\ArrayHelper::toObject.
2015-10-03T08:47:21+00:00   WARNING ::1 deprecated  This method is typehinted to be an array in \Joomla\Utilities\ArrayHelper::toString.
2015-10-03T08:47:21+00:00   WARNING ::1 deprecated  This method is typehinted to be an array in \Joomla\Utilities\ArrayHelper::getColumn.
2015-10-03T08:47:21+00:00   WARNING ::1 deprecated  This method is typehinted to be an array in \Joomla\Utilities\ArrayHelper::pivot.
2015-10-03T08:47:21+00:00   WARNING ::1 deprecated  This method is typehinted to be an array in \Joomla\Utilities\ArrayHelper::sortObjects.

However, I have still changed those 5 lines to fixed string for the method names.
Thanks.

I have tested this item unsuccessfully on ad48dac

@wilsonge Can you have a look at this too? Looks good to go for me.

@roland-d In your last comment you say 'looks good to me', but your recent test status says: tested unsuccessfully on ad48dac. Was there any issue?

@izharaazmi Look at the issue and the test results, I have set the test to successful after your last change.

Sorry, but I see the 2nd test too marked as 'tested unsuccessfully' only. May be I'm missing something!

I have tested this item successfully on ad48dac

Now it is successful :)

Thanks!

I have tested this item successfully on ad48dac

Applied the patch and worked for a while, no issues so far. Ok

RTC. for 3.5.0 Thanks.