[#7769] - Index category after save in finder plugin
- Closed
- 26 Aug 2015
- Medium
- Build: staging
- Easy Test
- # 7769
- Diff
- Digital-Peak:index-categories-on-save
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This is the PR for the issue #7711.
Steps to reproduce the issue
1) Have smart search enabled incl. "categories" finder plugin
2) Edit a category: change title/alias/description, but do not touch state or access. Save.
3) Search for a relevant keyword to get this category in search results
Expected result
Updated title/alias/description of the category in search result
Actual result
Old title/alias/descriptipon
System information (as much as possible)
Additional comments
I believe a closing bracket should be moved from line 136 to line 133 in categories.php finder plugin.
if (!$isNew && $this->old_access != $row->access)
{
// Process the change.
$this->itemAccessChange($row);
// Reindex the category item.
$this->reindex($row->id);
}to become
if (!$isNew && $this->old_access != $row->access)
{
// Process the change.
$this->itemAccessChange($row);
}
// Reindex the category item.
$this->reindex($row->id); | Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Easy | No | ⇒ | Yes |
| Category | ⇒ | Plugins |
@test unfortunately even after I apply the patch, the old data is shown in search result, here are the steps I followed:
- Changed a category title/alias/description
- Enabled smart search module in website frontend
- Tried to search for that category.
- In the search result I still see the old title/description of the category
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7769.
@watchfulli-dev did you enable the "Content - Smart Search" Plugin? Bevor you change something?
@watchfulli-dev After you have applied the patch you need to resave the category.
hmm can you check the backend view?
I can't reproduce this issue after applying this patch ;)
see:
backend category edit:
com_finder backend
com_finder frontend
And if i change the category in the backend i can see the changes that gets applyed to the frontend as well ;)
I guess the other smart seach plugin (Smart Search - Categories) is enabled as well ;)
@test Okay that worked now if I re-save category after applying the patch
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7769.
| Status | Pending | ⇒ | Ready to Commit |
Yes that is required as the plugin event run on saving ;) RTC'ing than. Thanks @watchfulli-dev and @laoneo !
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7769.
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
RickR2H
-
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-08-26 16:43:03 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
Merged into staging! Thanks!
Tested successfull. Thanks @laoneo
@tgv604 can you also test here? If you need help let me know. The quick step testing docu can be found here: https://docs.joomla.org/Testing_Joomla!_patches
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7769.