? ? Success

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
24 Aug 2015

This adds a message to the Plugin and fixes #7762 as this plugin needs to be there if you use the Joomla User Management.

Thanks @sisko1990

avatar zero-24 zero-24 - open - 24 Aug 2015
avatar zero-24 zero-24 - change - 24 Aug 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Aug 2015
Labels Added: ? ?
avatar zero-24 zero-24 - change - 24 Aug 2015
Milestone
avatar wilsonge
wilsonge - comment - 24 Aug 2015

This isn't actually strictly true. The reason why things fail is because the user is logged in successfully. But when disabled the user details aren't stored in the session and therefore when you redirect everything falls apart. Technically any plugin can store the user object in the session and it will work fine (joomla user management, cb user management, whatever). Tbh you might even be able to get away with not even storing it in the session (although at that stage JFactory::getUser might have issues.

avatar zero-24
zero-24 - comment - 25 Aug 2015

@wilsonge do you have a suggestion for a better message?

Something like?

Warning! You must have enabled at least on plugin that handle the user session management or you will lose all access to your site.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7763.

avatar zero-24 zero-24 - change - 25 Aug 2015
Category Language & Strings Plugins
avatar wilsonge
wilsonge - comment - 25 Aug 2015

This is @brianteeman territory but from a technical perspective that's much better than what you have at the moment

avatar laoneo
laoneo - comment - 27 Aug 2015

Agree with the comments. Feeling a bit awkward to hit the Test success button for language strings changes.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7763.

avatar laoneo laoneo - test_item - 27 Aug 2015 - Tested successfully
avatar zero-24
zero-24 - comment - 5 Oct 2015

@wilsonge I have updated it to that wording. Any problems with it @brianteeman ?

avatar brianteeman
brianteeman - comment - 5 Oct 2015

It should be ONE not ON
HANDLES not HANDLE

avatar joomla-cms-bot
joomla-cms-bot - comment - 5 Oct 2015

This PR has received new commits.

CC: @laoneo


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7763.

avatar zero-24
zero-24 - comment - 5 Oct 2015

oops some bad issues. Thanks @brianteeman fixed.

avatar zero-24 zero-24 - change - 6 Oct 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 6 Oct 2015

As it is just a language update there we have a review. --> RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7763.

avatar joomla-cms-bot joomla-cms-bot - change - 6 Oct 2015
Labels Added: ?
avatar rdeutz rdeutz - change - 6 Oct 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-10-06 19:29:54
Closed_By rdeutz
avatar rdeutz rdeutz - reference | a256f91 - 6 Oct 15
avatar rdeutz rdeutz - merge - 6 Oct 2015
avatar rdeutz rdeutz - close - 6 Oct 2015
avatar zero-24 zero-24 - head_ref_deleted - 6 Oct 2015
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone Added:
avatar zero-24 zero-24 - change - 28 Oct 2015
Milestone

Add a Comment

Login with GitHub to post a comment