? Success

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
24 Aug 2015

This PR fix some nonsense code.

The old way

$false = false;
[some checks]
return $false;

The new way

[some checks]
return false;
Note

I'm execluding administrator\components\com_joomlaupdate\restore.php as it is 3rd party code.

How to test

  • Access the following Backend edit views:

    • com_languages --> language
    • com_menus --> menu
    • com_modules --> modul
    • com_plguins --> plugin
    • com_templates --> style

or just review that code that is maybe the easyest version ;)

avatar zero-24 zero-24 - open - 24 Aug 2015
avatar zero-24 zero-24 - change - 24 Aug 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Aug 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 24 Aug 2015
Category Components
avatar zero-24 zero-24 - change - 24 Aug 2015
The description was changed
Easy No Yes
avatar n9iels
n9iels - comment - 24 Aug 2015

@test looks good to me :+1:


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7761.

avatar chmst
chmst - comment - 25 Aug 2015

@test - Good find :) as much as I see in my test environment, it is all fine.

avatar zero-24 zero-24 - change - 25 Aug 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 25 Aug 2015

Thanks. RTC'ing. Just fixed some merge conflicts.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7761.

avatar joomla-cms-bot joomla-cms-bot - change - 25 Aug 2015
Labels Added: ?
avatar zero-24 zero-24 - alter_testresult - 25 Aug 2015 - n9iels: Tested successfully
avatar zero-24 zero-24 - alter_testresult - 25 Aug 2015 - chmst: Tested successfully
avatar zero-24 zero-24 - change - 25 Aug 2015
Milestone Added:
avatar Bakual Bakual - change - 26 Aug 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-08-26 13:08:13
Closed_By Bakual
avatar Bakual Bakual - close - 26 Aug 2015
avatar joomla-cms-bot joomla-cms-bot - close - 26 Aug 2015
avatar Bakual Bakual - reference | f6d2d88 - 26 Aug 15
avatar Bakual Bakual - merge - 26 Aug 2015
avatar Bakual Bakual - close - 26 Aug 2015
avatar joomla-cms-bot joomla-cms-bot - change - 26 Aug 2015
Labels Removed: ?
avatar zero-24 zero-24 - head_ref_deleted - 26 Aug 2015
avatar zero-24
zero-24 - comment - 26 Aug 2015

Thanks @Bakual

Add a Comment

Login with GitHub to post a comment