Pending

User tests: Successful: Unsuccessful:

avatar ghost
ghost
8 Mar 2013

Added an isset check for a possible undefined index.

avatar nonumber nonumber - open - 8 Mar 2013
avatar nicksavov
nicksavov - comment - 9 Mar 2013

Thank you, Peter! Can we get some testing instructions though?

Tracker item:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=30260

avatar nonumber
nonumber - comment - 9 Mar 2013

I came across the PHP message when exiting the code for something else. Normally you won't see the PHP notice, because of the redirect after the save method for modules (in admin).

So not really a test instruction, unless you save a module and log all php messages/notices.
Or you need to put an 'exit' in the controller at the end of the save method (before the redirect).

But it is pretty much a code no-brainer. That method uses an array index that is possibly (and usually) not set. So it should be checked for it's existence before doing stuff with it.

avatar mbabker
mbabker - comment - 25 Mar 2013

Merged at 8b226cd

avatar mbabker mbabker - close - 25 Mar 2013
avatar nonumber nonumber - head_ref_deleted - 25 Mar 2013

Add a Comment

Login with GitHub to post a comment