[#7752] - Fix the missing lang strings for com_media
- Closed
- 24 Aug 2015
- Medium
- Build: staging
- # 7752
- Diff
- zero-24:missing_lang_strings
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This fixes: #7751 Thanks @tranduyhung and @infograf768
There are 2 language keys which I can't find them anywhere in Joomla language files
JLIB_APPLICATION_ERROR_CREATE_NOT_PERMITTED - used in
JERROR_CORE_CREATE_NOT_PERMITTED - used in
https://github.com/joomla/joomla-cms/blob/master/administrator/components/com_templates/models/style.php#L169 and https://github.com/joomla/joomla-cms/blob/master/administrator/components/com_modules/models/module.php#L398
If they are really missing. What language ini file should we add them to? Can we just simply say "Create not permitted." just like in com_media?
COM_MEDIA_ERROR_CREATE_NOT_PERMITTED="Create not permitted."
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
Thanks just fixed based on: https://github.com/joomla/user-interface-text/blob/master/punctuation.md#period
Thanks. :-)
| Category | ⇒ | Language & Strings |
| Status | Pending | ⇒ | Ready to Commit |
Based on @chrisdavenport 's en-GB Review and the comments by @tranduyhung and @infograf768 on #7751 I'm going to RTC here. Thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7752.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Information Required |
| Labels |
Removed:
?
|
||
Yes. One exists already in lang packs and can't be used globally. The new one is global.
@infograf768 Okay, I understand. Then it's good to be merged.
Thank you @zero-24!
| Status | Information Required | ⇒ | Ready to Commit |
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-08-24 08:13:09 |
| Closed_By | ⇒ | Kubik-Rubik |
| Milestone |
Added: |
||
Missing full stops at the end? Do we have a standard for that?