? Success

User tests: Successful: Unsuccessful:

avatar shur
shur
21 Aug 2015

This is a next portion of changes of this PR #4311

avatar shur shur - open - 21 Aug 2015
avatar shur shur - change - 21 Aug 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Aug 2015
Labels Added: ?
avatar shur shur - change - 21 Aug 2015
Title
[cs] All values are in quotes
[cs] field DEFAULT values are in quotes
avatar mbabker
mbabker - comment - 21 Aug 2015

There's obviously something I'm missing here. From a glance, all of these values you're quoting are integer values on integer field types, doesn't quoting them treat them as string values?

avatar shur
shur - comment - 23 Aug 2015

@mbabker
This PR is not about inserting some data and its values where your comment about quotes would be in place. This PR is about assigning column default values when mysql table is created. Adding quotes to default values cannot change data type of the column (string: CHAR, VARCHAR, numeric: INTEGER, SMALLINT, etc) because column data type is set in another place.

When I export current site database using phpMyAdmin tool and compare it to the standard joomla.sql file, absence of these quotes results in unnecessary minor differences that are irrelevant to real changes that I want to track. It makes the comparison work much harder and slower.

See what I mean:
site-db-comparison

avatar zero-24 zero-24 - change - 23 Aug 2015
Category Code style SQL
avatar roland-d
roland-d - comment - 14 Sep 2015

@mbabker I don't think MySQL is going to treat it as string because the field itself is defined as integer. I see no issues with this change, do you see any further issues?

avatar shur shur - change - 11 Dec 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-12-11 08:37:14
Closed_By shur
avatar shur shur - close - 11 Dec 2015
avatar shur shur - close - 11 Dec 2015
avatar shur shur - head_ref_deleted - 11 Dec 2015

Add a Comment

Login with GitHub to post a comment