User tests: Successful: Unsuccessful:
This PR adds the "No direct access" code to the read more layout.
Status | New | ⇒ | Pending |
Labels |
Added:
?
?
|
This readmore.php layout is indeed missing a defined('_JEXEC') or die;
or defined('JPATH_BASE') or die;
But this patch also adds JHtml::_('bootstrap.framework');
Please explain why.
My mistake =)
I saw this line
JHtml :: _ ('string.truncate', ($ item-> title), $ params-> get ('readmore_limit'));
and added,
JHtml :: _ ('bootstrap.framework’);
On 20 Aug 2015, at 13:20, infograf768 notifications@github.com wrote:
This readmore.php layout is indeed missing a defined('_JEXEC') or die; or defined('JPATH_BASE') or die;
But this patch also adds JHtml::_('bootstrap.framework');
Please explain why.—
Reply to this email directly or view it on GitHub #7731 (comment).
Labels |
Removed:
?
|
Category | ⇒ | Code style |
Category | Code style | ⇒ | Code style Layout |
I've tested successfully. But I don't unterstand why you have add the following lines.
// No direct access (this I unterstand. That's the Issue)
defined('JPATH_BASE') or die;
// this I don't understand. (why is the following lines required for this issue?)
JHtml::_('bootstrap.framework');
$params = $displayData['params'];
$item = $displayData['item'];
@xsability yes. There for i opend the pull here: buyanov#1 to fix that if @buyanov merge that PR into this we can go future here.
yeah! :)
I think this PR can be closed.
defined('JPATH_BASE') or die;
is present in 3.5.0beta in /layouts/joomla/content/readmore.php
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-01-17 11:15:13 |
Closed_By | ⇒ | brianteeman |
Closed as this was resolved in a later PR #8398
Please add more information to your issue. Without test instructions and/or any description we will close this issue soon. Thanks.
This is an automated message from the J!Tracker Application.