? Failure

User tests: Successful: Unsuccessful:

avatar buyanov
buyanov
20 Aug 2015

This PR adds the "No direct access" code to the read more layout.

avatar buyanov buyanov - open - 20 Aug 2015
avatar buyanov buyanov - change - 20 Aug 2015
Status New Pending
avatar joomla-cms-bot
joomla-cms-bot - comment - 20 Aug 2015

Please add more information to your issue. Without test instructions and/or any description we will close this issue soon. Thanks.
This is an automated message from the J!Tracker Application.

avatar joomla-cms-bot joomla-cms-bot - change - 20 Aug 2015
Labels Added: ? ?
avatar infograf768
infograf768 - comment - 20 Aug 2015

This readmore.php layout is indeed missing a defined('_JEXEC') or die; or defined('JPATH_BASE') or die;

But this patch also adds JHtml::_('bootstrap.framework');
Please explain why.

avatar buyanov
buyanov - comment - 20 Aug 2015

My mistake =)
I saw this line
JHtml :: _ ('string.truncate', ($ item-> title), $ params-> get ('readmore_limit'));
and added,
JHtml :: _ ('bootstrap.framework’);

On 20 Aug 2015, at 13:20, infograf768 notifications@github.com wrote:

This readmore.php layout is indeed missing a defined('_JEXEC') or die; or defined('JPATH_BASE') or die;

But this patch also adds JHtml::_('bootstrap.framework');
Please explain why.


Reply to this email directly or view it on GitHub #7731 (comment).

avatar zero-24
zero-24 - comment - 20 Aug 2015

@buyanov I have just send you a Fix. That makes Travis happy and remove the jhtml call.

avatar zero-24 zero-24 - change - 20 Aug 2015
The description was changed
Labels Removed: ?
avatar buyanov
buyanov - comment - 20 Aug 2015

????

avatar zero-24 zero-24 - change - 20 Aug 2015
Category Code style
avatar zero-24 zero-24 - change - 20 Aug 2015
Category Code style Code style Layout
avatar infograf768
infograf768 - comment - 20 Aug 2015

@buyanov
You have to merge @zero-24 PR ( buyanov#1 ) in your PR.

avatar xsability
xsability - comment - 27 Aug 2015

I've tested successfully. But I don't unterstand why you have add the following lines.
// No direct access (this I unterstand. That's the Issue)
defined('JPATH_BASE') or die;

// this I don't understand. (why is the following lines required for this issue?)
JHtml::_('bootstrap.framework');

$params = $displayData['params'];
$item = $displayData['item'];


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7731.

avatar xsability xsability - test_item - 27 Aug 2015 - Tested successfully
avatar zero-24
zero-24 - comment - 27 Aug 2015

@xsability yes. There for i opend the pull here: buyanov#1 to fix that :smile: if @buyanov merge that PR into this we can go future here.

avatar buyanov
buyanov - comment - 27 Aug 2015

yeah! :)

avatar bertmert
bertmert - comment - 17 Jan 2016

I think this PR can be closed.

defined('JPATH_BASE') or die;

is present in 3.5.0beta in /layouts/joomla/content/readmore.php

avatar brianteeman brianteeman - change - 17 Jan 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-01-17 11:15:13
Closed_By brianteeman
avatar brianteeman brianteeman - close - 17 Jan 2016
avatar brianteeman brianteeman - close - 17 Jan 2016
avatar brianteeman
brianteeman - comment - 17 Jan 2016

Closed as this was resolved in a later PR #8398


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7731.

Add a Comment

Login with GitHub to post a comment