? Success

User tests: Successful: Unsuccessful:

avatar pe7er
pe7er
16 Aug 2015

This PR moves Filters from left sidebar to Search Tools.

Testing instructions

Before this PR

  1. left side bar has 3 filter options that cannot be reset easily
  2. middle column has 2 filter options for ordering that duplicate the ordering of column headers.

plugins_filters_before

This PR should

  1. move Filters from sidebar to Search Tools in middle column. All filters can be reset with the "Clear" button.
  2. remove left sidebar
  3. remove "Type" + "Ascending" (Sort Table by + Select the ordering) fields because they are duplicate. The ordering field + ordering direction can be set by clicking on a column header (fieldname).

plugins_filters_after

avatar pe7er pe7er - open - 16 Aug 2015
avatar pe7er pe7er - change - 16 Aug 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Aug 2015
Labels Added: ?
avatar pe7er pe7er - change - 16 Aug 2015
Title
Moved Filters from sidebar to Search Tools
com_plugin - Moved Filters from sidebar to Search Tools
avatar zero-24 zero-24 - change - 17 Aug 2015
Category Administration UI/UX
avatar zero-24 zero-24 - change - 17 Aug 2015
Easy No Yes
avatar pe7er pe7er - reference | a398331 - 17 Aug 15
avatar pe7er
pe7er - comment - 17 Aug 2015

Thanks for all your Code Style corrections! @zero-24

avatar nonumber
nonumber - comment - 17 Aug 2015

Wasn't the whole idea to move away from the Search Tools and use the side bar instead?

avatar kathastaden kathastaden - test_item - 20 Aug 2015 - Tested successfully
avatar kathastaden
kathastaden - comment - 20 Aug 2015
  1. Move Filters from sidebar to Search Tools in middle column --> Done
  2. All filters can be reset with the "Clear" button --> Worked fine
  3. remove left sidebar --> Is removed
  4. remove "Type" + "Ascending" (Sort Table by + Select the ordering) fields because they are duplicate. The ordering field + ordering direction can be set by clicking on a column header (fieldname) --> They are removed and the ordering works fine with the column headers
  5. Search Tools --> Worked fine, search was correct
  6. I did not find any new bugs
    This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7699.
avatar hitchblade hitchblade - test_item - 20 Aug 2015 - Tested successfully
avatar watchfulli-dev
watchfulli-dev - comment - 21 Aug 2015

@test success, after applying the patch the filters from the left side now appear on top under "Search tools", tested filters and they work as expected.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7699.

avatar watchfulli-dev watchfulli-dev - test_item - 21 Aug 2015 - Tested successfully
avatar zero-24 zero-24 - change - 23 Aug 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 23 Aug 2015

Thanks for the tests and coding :smile: RTC'ing now


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7699.

avatar joomla-cms-bot joomla-cms-bot - change - 23 Aug 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 25 Aug 2015
Milestone Added:
avatar zero-24 zero-24 - change - 25 Aug 2015
Milestone Added:
avatar pe7er
pe7er - comment - 26 Aug 2015

Thanks for testing! @kathastaden & @watchfulli-dev


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7699.

avatar compojoom
compojoom - comment - 14 Sep 2015

@nonumber - that's what I'm wondering as well. Do we have a "design guide" or something? It would be stupid to have the filters once in search tools, then on the right. We should decide what we want to use and then stick to it.

avatar pe7er
pe7er - comment - 3 Nov 2015

New PR #8146 to replace this one.

avatar pe7er pe7er - change - 3 Nov 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-11-03 22:43:02
Closed_By pe7er
avatar pe7er pe7er - close - 3 Nov 2015
avatar joomla-cms-bot joomla-cms-bot - close - 3 Nov 2015
avatar pe7er pe7er - close - 3 Nov 2015
avatar joomla-cms-bot joomla-cms-bot - change - 3 Nov 2015
Labels Removed: ?
avatar zero-24 zero-24 - change - 4 Nov 2015
Milestone Removed:
avatar pe7er pe7er - head_ref_deleted - 5 Nov 2015

Add a Comment

Login with GitHub to post a comment