? ? Success

User tests: Successful: Unsuccessful:

avatar RickR2H
RickR2H
14 Aug 2015

The search label was not visible due to the class that was added. Also the Label default value was set to "Search ..." when the label text field was empty. This PR changes this so the label is not visible when the label text field is completely empty.

How to test:
Apply the patch and go to the Search module in position-0
Fill in a text in the Box Label field and save the module.
adminpanel-searchmod

The search label must now be visible on the front end of the website.
searchfield-withlabel

Remove the label and clear the text field completely. Also remove spaces! After that the label must be gone without errors on the front end of the website.
searchfield-withoutlabel

avatar RickR2H RickR2H - open - 14 Aug 2015
avatar RickR2H RickR2H - change - 14 Aug 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Aug 2015
Labels Added: ? ?
avatar infograf768
infograf768 - comment - 15 Aug 2015

We indeed have a contradiction here (proposing a label field that will be invisible since 2012 cd663c0 ) and, if it is decided to merge this, the tooltip has also to be changed:
screen shot 2015-08-15 at 09 03 04

avatar Bakual
Bakual - comment - 15 Aug 2015

I think the label is there but invisible on purpose to assist with screen readers. I wouldn't change that.
If you want to show it on your site, you can use layout overrides to achieve it.

avatar RickR2H
RickR2H - comment - 15 Aug 2015

@Bakual I get it. But it didn't make sense since there was a field you can put text in, but isn't visible in the front end. Is it then better plan to remove the label field? In my opinion it then has no use.

avatar rdeutz
rdeutz - comment - 15 Aug 2015

As @Bakual already said the label must be there for other assisting tools like screen readers. What might be discussable is if we should show the label when someone put text into the Box Label field. So that would mean we change the class for the label, when someone put text into the Box Label field in the backend.

avatar zero-24 zero-24 - change - 16 Aug 2015
Category Front End Modules
avatar RickR2H
RickR2H - comment - 16 Aug 2015

@rdeutz @Bakual I think it is an acceptable solution to change the class when the label box field is filled... Shall I implement this solution?

avatar Bakual
Bakual - comment - 16 Aug 2015

I'm not so sure. For those people who entered a value suddenly the label will appear in the module and depending on the template it could appear quite broken. Imho, the label never serves any purpose except for screen readers, and thus always can stay invisible.

I wonder what the issue is you're trying to solve. You can already show the label using a simple CSS rule. Or you can do a layout override in your template.

If the gain from this PR outweigths the potential B/C issue, then yes, we can do it. But currently I don't see any real gain.

avatar RickR2H
RickR2H - comment - 17 Aug 2015

I guess you are right @Bakual. The only thing that didn't make sense to me was the label box text field that didn't show when the field was filled. That's what triggered me to make the label visible. I'll close the PR.

avatar RickR2H RickR2H - change - 17 Aug 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-08-17 04:37:56
Closed_By RickR2H
avatar RickR2H RickR2H - close - 17 Aug 2015
avatar RickR2H RickR2H - head_ref_deleted - 17 Aug 2015

Add a Comment

Login with GitHub to post a comment