User tests: Successful: Unsuccessful:
The search label was not visible due to the class that was added. Also the Label default value was set to "Search ..." when the label text field was empty. This PR changes this so the label is not visible when the label text field is completely empty.
How to test:
Apply the patch and go to the Search module in position-0
Fill in a text in the Box Label field and save the module.
The search label must now be visible on the front end of the website.
Remove the label and clear the text field completely. Also remove spaces! After that the label must be gone without errors on the front end of the website.
Status | New | ⇒ | Pending |
Labels |
Added:
?
?
|
I think the label is there but invisible on purpose to assist with screen readers. I wouldn't change that.
If you want to show it on your site, you can use layout overrides to achieve it.
As @Bakual already said the label must be there for other assisting tools like screen readers. What might be discussable is if we should show the label when someone put text into the Box Label field. So that would mean we change the class for the label, when someone put text into the Box Label field in the backend.
Category | ⇒ | Front End Modules |
I'm not so sure. For those people who entered a value suddenly the label will appear in the module and depending on the template it could appear quite broken. Imho, the label never serves any purpose except for screen readers, and thus always can stay invisible.
I wonder what the issue is you're trying to solve. You can already show the label using a simple CSS rule. Or you can do a layout override in your template.
If the gain from this PR outweigths the potential B/C issue, then yes, we can do it. But currently I don't see any real gain.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-08-17 04:37:56 |
Closed_By | ⇒ | RickR2H |
We indeed have a contradiction here (proposing a label field that will be invisible since 2012 cd663c0 ) and, if it is decided to merge this, the tooltip has also to be changed: