? Success

User tests: Successful: Unsuccessful:

avatar izharaazmi
izharaazmi
13 Aug 2015

The key usage was like $this->$accept instead of $this->accept causing error undefined variable $accept.

I know this is a part of Joomla-framework/Form package, but that repo has changed drastically as compared to the current CMS copy. If this still not ok to PR here, please advise.

avatar izharaazmi izharaazmi - open - 13 Aug 2015
avatar izharaazmi izharaazmi - change - 13 Aug 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Aug 2015
Labels Added: ?
avatar Bakual
Bakual - comment - 13 Aug 2015

I know this is a part of Joomla-framework/Form package

It isn't that one. The packages coming from the framework are in https://github.com/joomla/joomla-cms/tree/staging/libraries/vendor/joomla

So this PR is perfectly fine here. :+1:

avatar wilsonge
wilsonge - comment - 13 Aug 2015

Merging on reivew

avatar wilsonge wilsonge - change - 13 Aug 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-08-13 18:00:15
Closed_By wilsonge
avatar wilsonge wilsonge - close - 13 Aug 2015
avatar wilsonge wilsonge - reference | b4026f5 - 13 Aug 15
avatar wilsonge wilsonge - merge - 13 Aug 2015
avatar wilsonge wilsonge - close - 13 Aug 2015
avatar Bakual Bakual - change - 13 Aug 2015
Milestone Added:
avatar izharaazmi izharaazmi - head_ref_deleted - 5 Sep 2015

Add a Comment

Login with GitHub to post a comment