[#7687] - Update of less compiler (leafo)
- Closed
- 26 Jan 2016
- Medium
- Build: staging
- Easy Test
- # 7687
- Diff
- dgt41:____less_0.5
- Success Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Joomla is using an outdated version of lessc
B/C
This should be 100% compatible with Bootstrap > 2.3 or any other less files that are using the same notation
Testing
Try to compile any less files (other than the ones Joomla is already shipping) and compare it with the previous copy. Should be identical.
It would be nice if you can apply #6979 and try to run generatecss.php, should work fine! Also since to already have applied that patch do some template switching and give to that one as well a response!
PS. There seems to be some border color clash for a sub template of Hathor, that needs some attention.
Protostar seems to get one more class for IE10, https://github.com/joomla/joomla-cms/blob/staging/media/jui/less/responsive-utilities.less#L9-L11
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
Joomla 3.x is IE8 and higher
@wilsonge actually this -ms- class is for IE10: https://github.com/joomla/joomla-cms/blob/staging/media/jui/less/responsive-utilities.less#L9-L11
The reason why we never updated beyong 0.3.9 was the B/C warning for 0.4.0:
http://leafo.net/lessphp/changelog.html
Warning: this release has some breaking changes. If you the old selector expression syntax (eg. Bootstrap 2.3) then it’s recommended to use 0.3.9.
Interesting that on leafo.net, the latest version still shows as 0.4.0, while the 0.5.0 release is tagged in GitHub since Nov 2014.
@Bakual Bootstrap moved away from that old selector expression before 0.4.0 even got out, so it should be ok to update our version.
I have no clue what it refers to. If Bootstrap 2.3.2 doesn't use that selector expression (whatever that is), then I guess we can safely update it.
However according to @nonumber in #6451 (comment), there are issues with 0.5.0.
@Bakual The errors @nonumber found are already been fixed in this PR (/cms/less/less.php)
v0.5.0 was not fine. Found issues with it (not inheriting overwritten variables)
Also @vess comment in another workgroup, which pointed to the fix:
multiple files in a row with the same instance fails... issue leafo/lessphp#594 fix that works is leafo/lessphp#607
I have no clue what it refers to. If Bootstrap 2.3.2 doesn't use that selector expression (whatever that is), then I guess we can safely update it.
@Bakual
old: (~".span@{index}") {.span(@index);}
new: .span@{index} {.span(@index);}
lukeapage/bootstrap@6b9bb54
Thanks!
zero-24
- | Easy | No | ⇒ | Yes |
| Category | ⇒ | External Library |
So are we OK to get this thing in or are there B/C concerns?
No B/C break with this
In that case, this needs to be tested.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7687.
I have tested this item 
successfully on 657c027
Applied the patch and changed the .less files in the isis and the protostar template to monitor the output. After that executed generatecss.php to generate the stylesheets. Everything seems to work and there where no errors.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7687.
This PR has received new commits.
CC: @RickR2H
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7687.
| Labels |
Added:
?
|
||
I have tested this item successfully on 675a878
>=IE10 support has been ended by Microsoft. So we can also end the support for >= J3.5
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7687.
(MS only ended support - they did not stop anyone from using it.)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7687.
What is the best way to test this? I'll test asap ;)
Just run php build/generate.php and see if the css's are all ok
It has to be php, for the low end servers that don't have grunt etc
its php build/generatecss.php right not php build/generate.php
I have tested this item successfully on 675a878
Test was successful! To test it I added extra styling to the end of the template.less file. Sources are getting compiled nicely!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7687.
| Status | Pending | ⇒ | Ready to Commit |
RTC then
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-01-26 21:12:29 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
You have to run "composer update leafo/lessphp" and update the Composer
lock file too. Otherwise things start to get very out of whack.
Run "composer update leafo/lessphp" then "composer install --no-dev" after
changing the version constraint in composer.json. The second command
uninstalls the dev dependencies that will get pulled in (by design so they
are locked to specific versions for the CI systems).
On Wednesday, August 12, 2015, Dimitris Grammatiko notifications@github.com
wrote: