[#7676] - Redirect loop when site is offline and home page sends a 404 (solves #7670)
- Closed
- 11 Aug 2015
- Medium
- Build: staging
- Easy Test
- # 7676
- Diff
- infograf768:offline404
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
See test instructions in #7670.
After patching, the site will exit with a message.
"This site is offline and the Home Page sends a 404 error. Please contact a site administrator."
Steps to reproduce the issue
Create a brand new 3.4.3 site
Trash the article related to the default menu item
Now set the site to offline from Global Configuration.
grab popcorn and watch the front end go to redirect loop.
Expected result
Site should show offline page
Actual result
Site shows redirect loop.
System information (as much as possible)
Fresh Joomla 3.4.3 install
Additional comments
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
| Category | ⇒ | Front End UI/UX |
| Rel_Number | 0 | ⇒ | 7670 |
| Relation Type | ⇒ | Pull Request for | |
| Easy | No | ⇒ | Yes |
just added the testinstructions maybe @dhaval-desai can test here also for RTC. Thanks.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7676.
Please do not merge - the language string is not in english
On 10 August 2015 at 19:34, zero-24 notifications@github.com wrote:
just added the testinstructions maybe @dhaval-desai
https://github.com/dhaval-desai can test here also for RTC. Thanks.
This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/7676
http://issues.joomla.org/tracker/joomla-cms/7676.—
Reply to this email directly or view it on GitHub
#7676 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
@test Indeed with J3.4.3 trashing article used by default menu item cause a redirect loop. After applying the patch it shows this message "This site is offline and the Home Page sends a 404 error. Please contact a site administrator." no more redirect loop.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7676.
It should be enough to just display
"This site is offline please contact a site administrator."
I disagree. The more important information (as it is in fact aimed at the site administrator), is that the home page sends a 404, as otherwise the message does not help.
If you consider it is not in good English, please propose something which includes the fact that we get a 404 for the Home page.
The site is offline - it does NOT matter that you tell someone its a 404.
it is enough to say the site is offline.
What is the benefit for saying it is a 404
On 11 August 2015 at 08:45, infograf768 notifications@github.com wrote:
It should be enough to just display
"This site is offline please contact a site administrator."I disagree. The more important information (as it is in fact aimed at the
site administrator), is that the home page sends a 404, as otherwise the
message does not help.
If you consider it is not in good English, please propose something which
includes the fact that we get a 404 for the Home page.—
Reply to this email directly or view it on GitHub
#7676 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
IMO if the site is offline, for the general viewing public (unauthenticated users), that should take precedence over the 404 response. Once a user has logged into the frontend of that offline site, then they should be made aware of the 404 (and I think that'll be handled with normal error handling routines in that case).
IMO if the site is offline, for the general viewing public (unauthenticated users), that should take precedence over the 404 response.
That's what I wonder with this issue. Why does it even check if the URL is a valid request when the site is offline? Shouldn't it just show that offline page right away when not authenticated? Imho it shouldn't even go into the component dispatching/routing stage and bail out earlier.
Imho it shouldn't even go into the component dispatching/routing stage and bail out earlier.
You must not be aware of how "bad" Joomla's offline mode is then 
http://magazine.joomla.org/issues/issue-feb-2011/item/378-how-offline-is-joomla-offline-mode
You must not be aware of how "bad" Joomla's offline mode is then
No, I wasn't. Funny thing that 
Folks, at reading http://magazine.joomla.org/issues/issue-feb-2011/item/378-how-offline-is-joomla-offline-mode it looks like this needs another solution than this bandaid.
Closing.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-08-11 15:10:52 |
| Closed_By | ⇒ | infograf768 |
@nikosdion
Time to implement a real solution I guess. 
If you don't care about backwards compatibility and you are happy with me disemboweling the JApplicationCms routing AND adding a hardcoded dependency to com_users deep in its new guts, sure enough, I can make a real offline mode.
BUT! Things Shall Break.
If your site depends on some plugin or component doing some important work (e.g. unpublish expiring subscriptions, update search indices, backup your site...) on a schedule and the site is REALLY off-line then you will perceive your site as broken. Is this something we are even allowed to think about in the 3.x release cycle?
Sure not, just teasing you...
So let's leave it broken :p
hmm works as described.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7676.