[#7663] - TOC links not shown as active
- Closed
- 12 Aug 2015
- Medium
- Build: staging
- Easy Test
- # 7663
- Diff
- mbabker:TOC-active
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
In articles with a TOC and pagebreaks, the 2nd or later page may not be displayed as active because the active class is not applied to the <li> element as demonstrated in Bootstrap's documentation.
Testing Instructions
Create an article that uses page breaks; this snippet can be pasted into an editor in HTML mode to accomplish the test:
<p>Page 1</p>
<hr title="Second Page" alt="second-page" class="system-pagebreak" />
<p>Page 2</p>Pre-test, when you navigate pages, the 2nd page will never highlight as active. Post patch, it does.
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
It should. That's fix now too.
| Category | ⇒ | Front End UI/UX |
| Easy | No | ⇒ | Yes |
@test it works, after applying the patch when navigating to second page it gets highlighted
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7663.
| Status | Pending | ⇒ | Ready to Commit |
Tested also the last changes successfull. Thanks 
I'm RTC'ing now.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7663.
| Labels |
Added:
?
|
||
Kubik-Rubik
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-08-12 14:10:41 |
| Closed_By | ⇒ | Kubik-Rubik |
| Labels |
Removed:
?
|
||
| Milestone |
Added: |
||
Hi there. Can you modify the second patch for me? My page break component worked as your first one, that is highlighting active links. However, when I want to highlight all of them when choosing "All pages", then the second patch is not working for me. Thanks.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7663.
success
able to reproduce then #7663 works as described and 2nd or later page displayed as active
question: when "All pages" is selected, then shouldn't all the pages displayed as active?
Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7663.