Feeling Lucky
?
[#7661] - Add closing div for all contact page formats in beez
- Closed
- 11 Aug 2015
- Medium
- Build: staging
- Easy Test
- # 7661
- Diff
- Harmageddon:beez-contact-closing-div
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
At the moment, the outer div (com_contact/contact/default.php, line 14) for a single contact page in the Beez override is opened in all display formats, but closed only for sliders.
This enables the closing div tag for all styles of the contact page in beez.
Testing instructions
- Create a contact linked to a user and enter some information (address, social media, misc. information).
- Create a menu item for the contact:
- Type: Single Contact
- Contact Display Options - Display Format: Tabs or Plain
- Set Beez3 as the template for this menu item (or as the default template for the whole site).
- View the menu item in front end. In the unlikely case that nothing looks broken, take a look at the HTML output with focus on opening and closing tags. You may test the page on https://validator.w3.org/, too.
- Apply the patch.
- Repeat step 4 for all three display formats (Sliders, Tabs, Plain). Make sure that all elements are closed correctly.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Templates (site) |
Kubik-Rubik
- | Milestone |
Added: |
||
| Easy | No | ⇒ | Yes |
watchfulli-dev
- comment
- 11 Aug 2015
@test successful. after applying the patch there's no more unclosed elements reported.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7661.
| Status | Pending | ⇒ | Ready to Commit |
zero-24
- comment
- 11 Aug 2015
RTC Thanks 
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7661.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-08-11 23:40:02 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
wilsonge
- comment
- 11 Aug 2015
Merged! Thank you!
Tested successful!. Works good. One more tester
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7661.