[#766] - Removed colors from Icomoon named icons
- Closed
- 5 May 2013
- Medium
- Build: master
- # 766
- Diff
- unknown repository
- Foreign ID 30257
User tests: Successful: Unsuccessful:
Tracker item: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=30257
Only the Joomla (JUI) icons classes will get the assigned colors. This way you can still use the original Icomoon classnames to get the icon without the color.
Example:
- icon-apply and icon-edit will be blue
- icon-pencil will not be specifically colored
This change should not change anything visually in the current Isis template (as it uses the JUI class names, and their styles remain the same). It does however give developers the ability to use the icons without the assigned colors.
Changes
- Removed color from original icomoon classes
- Added 'icon-default' classname (same as icon-featured)
- Changed use of icomoon classes to JUI classes where needed
- Changed use of JUI classes to icomoon classes in status modules (so the remain grey)
Testing Instructions
Check all the views in the administrator and see if any icons loose the color
Tracker item:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=30257
Peter, does this have any backward compatibility issues for custom extensions (including templates)? Also, could we get some testing instructions?
There may be 3rd party extensions that use the icomoon classname of one of those icons that will - because of this patch - not get the color automatically.
Those extensions should either use the JUI classname or add the colors via their own stylesheet.
But I take it that not many - if any - will have actually used the icomoon classnames, as core is using the JUI classnames and leads by example.
There aren't really any test instructions, as there are no core views using the icomoon classnames.
You could test it by simply placing this in an article or some custom code:
<button href="#" class="btn"><i class="icon-publish"></i> Green tick (JUI class)</button>
<button href="#" class="btn"><i class="icon-ok"></i> Tick with default text color (Icomoon class)</button>
In current code, both will get green ticks.
With path, the second should not be green, but normal text color (probably black).
Thanks Peter!
Peter, this takes off the colors from the multilanguage status module in . They are all black now.
Yeah, status modules should be monochrome
Please create a tracker in joomlacode and cross-reference here.