[#7646] - [com_media] Refactoring of thumbnails and details view
- Closed
- 12 Dec 2015
- Medium
- Build: 3.5-dev
- Easy Test
- # 7646
- Diff
- jissereitsma:new_com_media_jisse_01
- Pending Human Test Results: 0 Successful 1 Failed. Details
User tests: Successful: Unsuccessful:
Part of the refactoring work of @Buddhima (#3839) was to add better delete-actions and edit-actions for images. While working on updating his during a code sprint, we found that the current thumbnails and details view was lacking flexibility. This PR includes refactoring to allow for more flexible updating in future work.
This PR adds first of all JLayout files for delete() and edit() actions. Because an edit() action is currently missing (it is part of the bundled works of @Buddhima though), there is a simple check to see whether the "image" view is there or not. The delete() action has been refactored to use the Delete toolbar-button, instead of using its own link. This way, future checks in that Delete toolbar-button ("Hey, you did not select anything") also applies to these actions.
Because of these changes, the HTML has changed in various places as well: For instance, the icons have been made a little bit bigger. In future PRs, this code needs beautifying: Removing style-arguments with proper CSS rules, new CSS-rules for the thumbnail-sizes, etcetera.
For testing, apply the patch, and try to delete the various files in either Thumnails-view or Details-view: Use all types of files: Images, ZIP-files, PDF-files. Try to delete an empty folder as well. And try to delete a non-empty folder - because it should not work ;)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
@jissereitsma Could you please merge @zero-24's PR against your branch so that we make Travis happy? Thanks! :-)
| Category | ⇒ | Media Manager |
| Easy | No | ⇒ | Yes |
Many thanks, @zero-24 @Kubik-Rubik. The PR is merged in my branch.
I'm getting some notices:
@test I just had a play around with this and it seems like a good improvement to me :) The view in com_media was significantly better. No apparent issues using the image editor-xtd button either in frontend or backend editing.
My only slight issue was that I felt using the preview button wasn't 100% obvious as it was a relatively small icon. I would reintroduce clicking on the image also opening the preview to make things easy for users
I have tested this item 
unsuccessfully on e6d05a6
The Patch is not OK.
- In the thumbnail-view and the detail-view of the backend the delete-button next to create-new-folder-button is without function.
- If you select more than one picture in the thumbnail-view and if you click on the red x of one picture, you will delete all chosen (I do not know if this is an issue).
- In the detail-view it is not possible to choose all pictures with the check-all checkbox. This is OK:
- You are not able to delete a folder if there are still pictures in.
Regards Markus
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7646.
@jissereitsma Is this obsolete with the new work you are doing on the media manager?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7646.
Yes, it is. Can you close this PR?
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-12-12 09:03:20 |
| Closed_By | ⇒ | brianteeman |
Closed as requested
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7646.
You appear to have added an empty file? (https://github.com/jissereitsma/joomla-cms/blob/new_com_media_jisse_01/administrator/components/com_media/controllers/image.php)