[#7613] - Add microdata to breadcrumbs
- Closed
- 6 Aug 2015
- Medium
- Build: staging
- Easy Test
- # 7613
- Diff
- n9iels:breadcrumb-microdata
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This PR add Micro Structured Data to the Joomla! breadcrumbs. I followed this guide lines: https://developers.google.com/structured-data/breadcrumbs
Also add some code style and change some if ($condition) { to if ($condition) : to make the code more readable.
Test instructions
Confirm that all parameters are working correct like they used do
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
@Fedik Thanks for noticing that :)
I add the <meta property="position" content="<POSITION_NUM>"> with help of the $key variable. But because it has to start with 1 instead of 0, I use $key + 1. I'm not sure if this is best way or not. Is there someone who think there is a better way to do this?
thanks!
$key + 1 is fine 
| Category | ⇒ | Front End Modules |
| Easy | No | ⇒ | Yes |
Test OK.
I am not very much into microdata, but the HTML generated looks allright.
| Status | Pending | ⇒ | Ready to Commit |
RTC Thanks 
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7613.
| Labels |
Added:
?
|
||
Tested with Google's Structured data tester:
hm, @peterlose on your test result still missed position
Strange, my test results where good. Did you fetch the last data?
Shoundn't position be itemprop as well? meta property is for RDFA
<meta itemprop="position" content="x" />
@peterlose right, I just noticed this also
@n9iels sorry, I gave you the wrong example, before
Changed it, thx for testing
Kubik-Rubik
- | Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-08-06 07:13:19 |
| Closed_By | ⇒ | Kubik-Rubik |
| Labels |
Removed:
?
|
||
looks good,
but changing
ultoolcan have side effect for people who useulas selector in the breadcrumbs styling, I think better keepuland I do not see
<meta property="position" content="<POSITION_NUM>">, that need for each item